From 512c6640fc4735b18ea0087e9dd8824e4cfb4e94 Mon Sep 17 00:00:00 2001 From: steveny91 Date: Wed, 27 Mar 2024 13:32:33 -0400 Subject: [PATCH 1/5] argo rollouts rec monitor --- .../assets/monitors/rollout_phase.json | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 argo_rollouts/assets/monitors/rollout_phase.json diff --git a/argo_rollouts/assets/monitors/rollout_phase.json b/argo_rollouts/assets/monitors/rollout_phase.json new file mode 100644 index 0000000000000..8102fc5493fb2 --- /dev/null +++ b/argo_rollouts/assets/monitors/rollout_phase.json @@ -0,0 +1,33 @@ +{ + "version": 2, + "created_at": "2024-03-27", + "last_updated_at": "2024-03-27", + "title": "Argo Rollout is in Non Running or Completed State", + "tags": [ + "integration:argo_rollouts" + ], + "description": "The Argo Rollout phase is the stage or status of a deployment or rollout process. This monitor tracks the phase of rollouts and alerts when a rollout is in a non running and completed state.", + "definition": { + "message": "{{#is_alert}}\nArgo Rollout {{argo_rollouts_name.name}} from {{argo_rollouts_namespace.name}} namespace is in a {{phase.name}} state for the last 10 minutes.\n{{/is_alert}}\n\n{{#is_recovery}}\nArgo Rollout {{argo_rollouts_name.name}} from {{argo_rollouts_namespace.name}} namespace is back in a stable state.\n{{/is_recovery}}", + "name": "[Argo Rollouts] Rollout Phase State", + "options": { + "include_tags": true, + "new_group_delay": 60, + "notify_audit": false, + "notify_no_data": false, + "renotify_interval": 0, + "require_full_window": false, + "avalanche_window": 10, + "thresholds": { + "critical": 1 + } + }, + "priority": null, + "query": "min(last_10m):avg:argo_rollouts.rollout.info{phase:abort or phase:error or phase:timeout or phase:invalidspec} by {phase,argo_rollouts_name,argo_rollouts_namespace,host} >= 1", + "restricted_roles": null, + "tags": [ + "integration:argo_rollouts" + ], + "type": "query alert" + } +} \ No newline at end of file From c55f554a69342d2d1eb66e3e3f1baf1d6cee3778 Mon Sep 17 00:00:00 2001 From: steveny91 Date: Wed, 27 Mar 2024 13:33:50 -0400 Subject: [PATCH 2/5] argo rollouts rec monitor manifest --- argo_rollouts/manifest.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/argo_rollouts/manifest.json b/argo_rollouts/manifest.json index dfdb9d3a51178..e7c708232ca33 100644 --- a/argo_rollouts/manifest.json +++ b/argo_rollouts/manifest.json @@ -51,6 +51,9 @@ }, "logs": { "source": "argo_rollouts" + }, + "monitors": { + "Rollout Phase": "assets/monitors/rollout_phase.yaml" } }, "author": { From f9de766803cc5c949fd1f044e6a0414d0e3ff473 Mon Sep 17 00:00:00 2001 From: steveny91 Date: Wed, 27 Mar 2024 13:39:38 -0400 Subject: [PATCH 3/5] fix query --- argo_rollouts/assets/monitors/rollout_phase.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/argo_rollouts/assets/monitors/rollout_phase.json b/argo_rollouts/assets/monitors/rollout_phase.json index 8102fc5493fb2..a86147ae678b5 100644 --- a/argo_rollouts/assets/monitors/rollout_phase.json +++ b/argo_rollouts/assets/monitors/rollout_phase.json @@ -23,7 +23,7 @@ } }, "priority": null, - "query": "min(last_10m):avg:argo_rollouts.rollout.info{phase:abort or phase:error or phase:timeout or phase:invalidspec} by {phase,argo_rollouts_name,argo_rollouts_namespace,host} >= 1", + "query": "min(last_10m):default_zero(avg:argo_rollouts.rollout.info{phase:abort or phase:error or phase:timeout or phase:invalidspec} by {phase,argo_rollouts_name,argo_rollouts_namespace,host}) >= 1", "restricted_roles": null, "tags": [ "integration:argo_rollouts" From 39d6105e9199e8c491bee17aa9ca7d2aaeba4836 Mon Sep 17 00:00:00 2001 From: steveny91 Date: Wed, 27 Mar 2024 13:43:58 -0400 Subject: [PATCH 4/5] fix manifest --- argo_rollouts/manifest.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/argo_rollouts/manifest.json b/argo_rollouts/manifest.json index e7c708232ca33..a6295454f7a1d 100644 --- a/argo_rollouts/manifest.json +++ b/argo_rollouts/manifest.json @@ -53,7 +53,7 @@ "source": "argo_rollouts" }, "monitors": { - "Rollout Phase": "assets/monitors/rollout_phase.yaml" + "Rollout Phase": "assets/monitors/rollout_phase.json" } }, "author": { From f357a2a34f6f28af664635e41c5ba8f82b558e87 Mon Sep 17 00:00:00 2001 From: steveny91 Date: Wed, 27 Mar 2024 13:55:09 -0400 Subject: [PATCH 5/5] fix tags --- argo_rollouts/assets/monitors/rollout_phase.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/argo_rollouts/assets/monitors/rollout_phase.json b/argo_rollouts/assets/monitors/rollout_phase.json index a86147ae678b5..5dd8ae49def0b 100644 --- a/argo_rollouts/assets/monitors/rollout_phase.json +++ b/argo_rollouts/assets/monitors/rollout_phase.json @@ -4,7 +4,7 @@ "last_updated_at": "2024-03-27", "title": "Argo Rollout is in Non Running or Completed State", "tags": [ - "integration:argo_rollouts" + "integration:argo-rollouts" ], "description": "The Argo Rollout phase is the stage or status of a deployment or rollout process. This monitor tracks the phase of rollouts and alerts when a rollout is in a non running and completed state.", "definition": {