You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
chore(benchmarks): combine ddtrace-run and startup benchmarks (#13391)
ddtrace-run benchmarks are broken, this PR removes this benchmarking
scenario and combines it with the new `startup` scenario.
Issues with ddtrace-run benchmarks:
- telemetry variants do not enable/disable the generation of telemetry
events. To record a telemetry event on application start up
`_DD_INSTRUMENTATION_TELEMETRY_TESTS_FORCE_APP_STARTED` must be set to
true. Otherwise telemetry events will be recorded 10 seconds after
ddtrace instrumentation is applied
- http proxy does not mock tracer-agent connections. We set the trace
api version to v0.4 but then mock requests to the v0.5 endpoint. This
does not make sense.
- ddtrace-run benchmarks do not mock statsd connections. So the baseline
that attempts to disable all http/udp/unix connections is inaccurate
## Checklist
- [ ] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
0 commit comments