Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing Predis Service Override #3098

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

PROFeNoM
Copy link
Contributor

Description

Fixes #3097

I think Predis was simply forgotten at the time of the implementation, so here is a proposition.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM self-assigned this Feb 20, 2025
@PROFeNoM PROFeNoM requested review from a team as code owners February 20, 2025 10:58
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.75%. Comparing base (445f72a) to head (8f66ceb).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3098   +/-   ##
=========================================
  Coverage     74.74%   74.75%           
- Complexity     2791     2792    +1     
=========================================
  Files           112      112           
  Lines         11044    11046    +2     
=========================================
+ Hits           8255     8257    +2     
  Misses         2789     2789           
Flag Coverage Δ
tracer-php 74.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../DDTrace/Integrations/Predis/PredisIntegration.php 92.50% <100.00%> (+0.12%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 445f72a...8f66ceb. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Feb 20, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-02-20 11:24:24

Comparing candidate commit 8f66ceb in PR branch alex/GH-3097_predis-service with baseline commit 445f72a in branch master.

Found 1 performance improvements and 2 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileBaseline

  • 🟥 execution_time [+60.721µs; +225.319µs] or [+2.064%; +7.659%]

scenario:PDOBench/benchPDOBaseline

  • 🟩 execution_time [-17.951µs; -14.189µs] or [-8.997%; -7.111%]

scenario:PDOBench/benchPDOBaseline-opcache

  • 🟥 execution_time [+13.391µs; +16.187µs] or [+7.278%; +8.798%]

Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!

@PROFeNoM PROFeNoM merged commit 2a55349 into master Feb 20, 2025
684 of 706 checks passed
@PROFeNoM PROFeNoM deleted the alex/GH-3097_predis-service branch February 20, 2025 12:57
@github-actions github-actions bot added this to the 1.7.0 milestone Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Service override not working with the Predis integration
3 participants