Amend login failure event being reported by mistake #3092
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3092 +/- ##
=========================================
Coverage 74.74% 74.74%
- Complexity 2790 2791 +1
=========================================
Files 112 112
Lines 11042 11044 +2
=========================================
+ Hits 8253 8255 +2
Misses 2789 2789
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Benchmarks [ tracer ]Benchmark execution time: 2025-02-18 12:21:34 Comparing candidate commit c6ffdcf in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 176 metrics, 0 unstable metrics. scenario:ContextPropagationBench/benchInject64Bit
scenario:TraceSerializationBench/benchSerializeTrace
|
estringana
force-pushed
the
estringana/fix-wordpress-login-events
branch
from
fc943a1 to
1612f88
Compare
| @@ -45,6 +45,15 @@ public function testUserLoginSuccessEvent() | |||
| $this->assertEquals($name, $events[0]['metadata']['name']); | |||
| } | |||
|
|
|||
| public function testHittingLoginPageDoesNotGenerateUserEvent() | |||
There was a problem hiding this comment.
This new tests ensures the bug is not happening
| /** | ||
| * @group appsec | ||
| */ | ||
| class AutomatedLoginEventsTest extends AutomatedLoginEventsTestSuite |
There was a problem hiding this comment.
Automated login event tests were not tested in Wordpress 6.1. This makes all these tests to be executed
estringana
force-pushed
the
estringana/fix-wordpress-login-events
branch
from
1612f88 to
b6cdc6b
Compare
|
The changes done to the |
estringana
force-pushed
the
estringana/fix-wordpress-login-events
branch
from
c5f8a25 to
c6ffdcf
Compare
Description
It was reported that wodpress was reporting many login failure events when they should not be reported. After investigation it was spotted that whenever the login page was hit(even with a get), the login failure event was reported. This PR fixes that.
Additionaly, user login events were not tested on Wordpress 6.1. This pr takes the opportunity to make those tests run
APPSEC-56789
Reviewer checklist