-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTel Integration tracking #3084
Conversation
bwoebi
commented
Feb 13, 2025
- Fires app-integration-changed events whenever a CachedInstrumentation object is constructed. (this generally happens once in constructors of well-behaving OTel integrations.
- Adds a component tag to spans created from a tracer created by the CachedInstrumentation object.
347b58d
to
8d10145
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (60.86%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #3084 +/- ##
============================================
- Coverage 73.04% 73.02% -0.02%
Complexity 2792 2792
============================================
Files 139 140 +1
Lines 15284 15307 +23
Branches 1047 1047
============================================
+ Hits 11164 11178 +14
- Misses 3567 3576 +9
Partials 553 553
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Benchmarks [ tracer ]Benchmark execution time: 2025-02-20 23:35:54 Comparing candidate commit b179d88 in PR branch Found 2 performance improvements and 1 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics. scenario:LogsInjectionBench/benchLogsInfoInjection-opcache
scenario:PDOBench/benchPDOBaseline
scenario:PDOBench/benchPDOBaseline-opcache
|
ae5c5bb
to
e14ac37
Compare
8d10145
to
2f499ed
Compare
cb41689
to
fbd4882
Compare
2f499ed
to
09c2779
Compare
Signed-off-by: Bob Weinand <[email protected]>
09c2779
to
468ee74
Compare
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Added one comment, but it's more a nit than anything else; doesn't really matter.
public function spanBuilder(string $spanName): \OpenTelemetry\API\Trace\SpanBuilderInterface | ||
{ | ||
$spanBuilder = $this->tracer->spanBuilder($spanName); | ||
//print new \Exception; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this should be removed?