From ae0c522b08f343460019c670f56963e38f89ea50 Mon Sep 17 00:00:00 2001 From: Alexandre Choura Date: Mon, 10 Feb 2025 09:33:10 +0100 Subject: [PATCH 1/2] fix: PackageUpdater failure --- tests/PackageUpdater.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/PackageUpdater.php b/tests/PackageUpdater.php index 9d73d81ee0..2d946f75ba 100644 --- a/tests/PackageUpdater.php +++ b/tests/PackageUpdater.php @@ -68,7 +68,7 @@ private function processFile(string $file): void $this->updatePackageVersion($library, $composer); } catch (Throwable $e) { - $this->errors[] = "Error processing $file: " . $e->getMessage(); + $this->errors[] = "Error processing $file: " . $e->getMessage() . PHP_EOL . $e->getTraceAsString(); } } @@ -91,7 +91,9 @@ private function findComposerFile(string $className, string $file): ?string { foreach (['getAppIndexScript', 'getConsoleScript'] as $method) { if (method_exists($className, $method)) { - $dir = dirname(call_user_func([$className, $method])); + $scriptPath = call_user_func([$className, $method]); + if (!$scriptPath) continue; + $dir = dirname($scriptPath); while (basename($dir) !== 'Frameworks') { $possible = "$dir/composer.json"; if (file_exists($possible)) { From 8427e87864b2a6cbded7b80b503cb2a7304b042d Mon Sep 17 00:00:00 2001 From: Alexandre Choura Date: Mon, 10 Feb 2025 09:36:15 +0100 Subject: [PATCH 2/2] exit 1 on failure --- tests/PackageUpdater.php | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/PackageUpdater.php b/tests/PackageUpdater.php index 2d946f75ba..aa3ed0c6d7 100644 --- a/tests/PackageUpdater.php +++ b/tests/PackageUpdater.php @@ -180,6 +180,7 @@ private function displaySummary(): void foreach ($this->errors as $error) { echo "- $error\n"; } + exit(1); } } }