fix: root span name in Slim V4 #3020
Conversation
PROFeNoM
force-pushed
the
alex/APMS-14231_slim-4-root-span-name
branch
from
c76e61b to
51f7631
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3020 +/- ##
=========================================
Coverage 74.80% 74.80%
Complexity 2781 2781
=========================================
Files 112 112
Lines 11017 11017
=========================================
Hits 8241 8241
Misses 2776 2776
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
| @@ -34,6 +34,7 @@ function ($app) use ($integration, $appName) { | |||
| // Overwrite root span info | |||
| $rootSpan = \DDTrace\root_span(); | |||
| $integration->addTraceAnalyticsIfEnabled($rootSpan); | |||
| $rootSpan->name = 'slim.request'; | |||
There was a problem hiding this comment.
Q: Can this be overwritten?
A lot of our notebooks & dashboarding are configured on web.request, so it would be a shame if everything needs to be updated again.
Kinda would consider this a breaking change, especially since also monitors and such probably rely on this value.
There was a problem hiding this comment.
You can easily overwrite it with \DDTrace\root_span()->name = 'web.request'; at the end of your entrypoint for example.
Description
I couldn't find a reason for the root span name to differ in Slim 3 compared to Slim 4. Furthermore, setting it to
slim.requestis consistent with all other integrations.This behavior was identified in the linked escalation.
Reviewer checklist