Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use-after-free with live-debugger #2989

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Dec 11, 2024

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@iamluc iamluc changed the title Fix user-after-free with debugger Fix user-after-free with live-debugger Dec 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.72%. Comparing base (0d57b55) to head (46f596d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2989   +/-   ##
=========================================
  Coverage     72.72%   72.72%           
  Complexity     2750     2750           
=========================================
  Files           138      138           
  Lines         15060    15060           
  Branches       1026     1026           
=========================================
  Hits          10953    10953           
  Misses         3548     3548           
  Partials        559      559           
Flag Coverage Δ
appsec-extension 67.95% <ø> (ø)
tracer-php 74.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d57b55...46f596d. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Dec 11, 2024

Benchmarks [ tracer ]

Benchmark execution time: 2024-12-19 13:23:15

Comparing candidate commit 46f596d in PR branch luc/fix-use-after-free-ephemeral-props with baseline commit 0d57b55 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 176 metrics, 0 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileOverhead-opcache

  • 🟩 execution_time [-183.278µs; -69.242µs] or [-5.357%; -2.024%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4-opcache

  • 🟩 execution_time [-438.846ns; -148.154ns] or [-6.187%; -2.089%]

@iamluc iamluc force-pushed the luc/fix-use-after-free-ephemeral-props branch 2 times, most recently from bad942c to acd6c7f Compare December 11, 2024 10:27
@iamluc iamluc marked this pull request as ready for review December 11, 2024 10:49
@iamluc iamluc requested a review from a team as a code owner December 11, 2024 10:49
@iamluc iamluc marked this pull request as draft December 11, 2024 16:35
@iamluc iamluc changed the title Fix user-after-free with live-debugger Fix use-after-free with live-debugger Dec 11, 2024
@iamluc iamluc force-pushed the luc/fix-use-after-free-ephemeral-props branch from dc406ff to 7d0be10 Compare December 12, 2024 14:28
@iamluc iamluc force-pushed the luc/fix-use-after-free-ephemeral-props branch from 3c85fc7 to 46f596d Compare December 19, 2024 12:54
@iamluc iamluc marked this pull request as ready for review January 2, 2025 14:17
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

@bwoebi bwoebi merged commit cc11b8e into master Jan 7, 2025
714 of 752 checks passed
@bwoebi bwoebi deleted the luc/fix-use-after-free-ephemeral-props branch January 7, 2025 13:20
@github-actions github-actions bot added this to the 1.6.0 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants