Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase read timeout of sidecar for synchronous flushes #2910

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Oct 22, 2024

Flushing sometimes takes longer than 1 second, so we would emit WouldBlock and CI would fail.

@bwoebi bwoebi requested review from a team as code owners October 22, 2024 17:20
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (dc68545) to head (3012492).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2910      +/-   ##
============================================
+ Coverage     78.21%   80.91%   +2.70%     
  Complexity     2526     2526              
============================================
  Files           173      146      -27     
  Lines         18752    14714    -4038     
  Branches        988        0     -988     
============================================
- Hits          14667    11906    -2761     
+ Misses         3544     2808     -736     
+ Partials        541        0     -541     
Flag Coverage Δ
appsec-extension ?
tracer-extension 78.11% <ø> (ø)
tracer-php 82.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc68545...3012492. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Oct 22, 2024

Benchmarks [ tracer ]

Benchmark execution time: 2024-10-22 17:47:46

Comparing candidate commit 3012492 in PR branch bob/timeout with baseline commit dc68545 in branch master.

Found 2 performance improvements and 2 performance regressions! Performance is the same for 174 metrics, 0 unstable metrics.

scenario:ContextPropagationBench/benchInject64Bit-opcache

  • 🟩 execution_time [-693.828ns; -346.172ns] or [-8.574%; -4.278%]

scenario:PDOBench/benchPDOBaseline-opcache

  • 🟩 execution_time [-14.433µs; -8.563µs] or [-7.588%; -4.502%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3-opcache

  • 🟥 execution_time [+193.331ns; +507.269ns] or [+2.828%; +7.421%]

scenario:TraceFlushBench/benchFlushTrace

  • 🟥 execution_time [+1000.000ns; +1000.000ns] or [+100.000%; +100.000%]

@bwoebi bwoebi merged commit 6d97821 into master Oct 23, 2024
408 of 443 checks passed
@bwoebi bwoebi deleted the bob/timeout branch October 23, 2024 08:01
@github-actions github-actions bot added this to the 1.5.0 milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants