Track DD_TRACE_DEBUG=1 errors in integration and web tests #2472
Conversation
Fix reporting @-suppressed errors within the sandbox. Also prefix all ddtrace errors with [ddtrace] [loglevel] to make them easily greppable. Signed-off-by: Bob Weinand <[email protected]>
BenchmarksBenchmark execution time: 2024-01-15 17:00:32 Comparing candidate commit 431b32e in PR branch Found 3 performance improvements and 2 performance regressions! Performance is the same for 34 metrics, 51 unstable metrics. scenario:HookBench/benchHookOverheadInstallHookOnFunction
scenario:HookBench/benchHookOverheadInstallHookOnMethod
scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:PHPRedisBench/benchRedisOverhead
scenario:SamplingRuleMatchingBench/benchRegexMatching4
|
| zend_replace_error_handling(EH_NORMAL, NULL, NULL); | ||
| EG(error_reporting) = 0; |
There was a problem hiding this comment.
Why are we adding the EG(error_reporting) = 0; instruction here? Isn't zend_replace_error_handling(EH_NORMAL, NULL, NULL); already doing that considering that EH_NORMAL equals zero
There was a problem hiding this comment.
No, EH_NORMAL and EH_THROW are the values, and it means that errors should not throw. EG(error_reporting) is the actual error level.
There was a problem hiding this comment.
Oh yeah, misread error_handling for error_reporting 😬
Description
Fix reporting @-suppressed errors within the sandbox.
Also prefix all ddtrace errors with
[ddtrace] [loglevel]to make them easily greppable.Reviewer checklist