feat(profiler) make the profiler compile in ZTS PHP #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-01-12 14:28:22 Comparing candidate commit dc22b51 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 3 unstable metrics. |
realFlowControl
force-pushed
the
florian/make-compile-with-zts
branch
from
81af83d to
2e11e20
Compare
realFlowControl
force-pushed
the
florian/make-compile-with-zts
branch
2 times, most recently
from
f2360ad to
52a23af
Compare
realFlowControl
force-pushed
the
florian/make-compile-with-zts
branch
from
52a23af to
dc22b51
Compare
morrisonlevi
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: This does not make the profiler ZTS compatible, it only ensures that it is compiling against a ZTS version of PHP
This PR will additionally add ZTS PHP version to the
prof_correctnesstests. Even though this seems awesome, please note that this test currently only runs one thread, so it is expected to not fail 😉PROF-8904
Reviewer checklist