Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase revolutions of context propagation benchmarks #2461

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

PROFeNoM
Copy link
Contributor

Description

These benchmarks are flaky, particularly because of their short execution time, which is too short for microtime's precision. Increasing revolutions may address this issue.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM self-assigned this Jan 11, 2024
@PROFeNoM PROFeNoM requested a review from a team as a code owner January 11, 2024 16:19
@PROFeNoM PROFeNoM force-pushed the alex/bench/flaky-revs branch from 17fdeac to 5237b4c Compare January 12, 2024 08:33
@pr-commenter
Copy link

pr-commenter bot commented Jan 12, 2024

Benchmarks

Benchmark execution time: 2024-01-12 09:03:13

Comparing candidate commit 5237b4c in PR branch alex/bench/flaky-revs with baseline commit b032b1e in branch master.

Found 6 performance improvements and 1 performance regressions! Performance is the same for 34 metrics, 49 unstable metrics.

scenario:ContextPropagationBench/benchExtractHeaders128Bit

  • 🟩 execution_time [-6.537µs; -6.215µs] or [-89.959%; -85.527%]

scenario:ContextPropagationBench/benchExtractHeaders64Bit

  • 🟩 execution_time [-12.627µs; -11.548µs] or [-94.233%; -86.178%]

scenario:ContextPropagationBench/benchExtractTraceContext128Bit

  • 🟩 execution_time [-12.550µs; -11.993µs] or [-85.375%; -81.585%]

scenario:ContextPropagationBench/benchExtractTraceContext64Bit

  • 🟩 execution_time [-6.572µs; -6.183µs] or [-90.654%; -85.277%]

scenario:ContextPropagationBench/benchInject128Bit

  • 🟩 execution_time [-12.708µs; -12.315µs] or [-85.287%; -82.652%]

scenario:ContextPropagationBench/benchInject64Bit

  • 🟩 execution_time [-31.652µs; -30.036µs] or [-82.643%; -78.422%]

scenario:PHPRedisBench/benchRedisBaseline

  • 🟥 execution_time [+88.984µs; +326.630µs] or [+2.935%; +10.775%]

@PROFeNoM PROFeNoM merged commit f07b0fc into master Jan 16, 2024
5 checks passed
@PROFeNoM PROFeNoM deleted the alex/bench/flaky-revs branch January 16, 2024 10:59
@github-actions github-actions bot added this to the 0.97.0 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants