Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase iterations of flaky benchmarks #2458

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Increase iterations of flaky benchmarks #2458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c6f82d
fix: Increase iterations of flaky benchmarks
PROFeNoM Jan 10, 2024
00d2dc7
Increase iterations of PDOBench
PROFeNoM Jan 10, 2024
f85edc2
Rerun benchmarks on changes to `tests/Benchmarks/**/*`
PROFeNoM Jan 11, 2024
948f0f7
Rerun benchmarks on changes to `benchmark`
PROFeNoM Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitlab/benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ benchmarks-tracer:
- ext/**/*
- src/**/*
- zend_abstract_interface/**/*
- tests/Benchmarks/**/*
- benchmark/*
compare_to: "master"
when: on_success
- when: manual
Expand Down
2 changes: 1 addition & 1 deletion tests/Benchmarks/API/ContextPropagationBench.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public function benchExtractTraceContext64Bit()

/**
* @Revs(1)
* @Iterations(10)
* @Iterations(15)
* @OutputTimeUnit("microseconds")
* @RetryThreshold(10.0)
* @BeforeMethods("resetContext")
Expand Down
6 changes: 3 additions & 3 deletions tests/Benchmarks/Integrations/PDOBench.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class PDOBench
/**
* @BeforeMethods({"disablePDOIntegration"})
* @Revs(100)
* @Iterations(5)
* @Iterations(15)
* @OutputTimeUnit("microseconds")
* @RetryThreshold(10.0)
*/
Expand All @@ -34,7 +34,7 @@ public function benchPDOBaseline()
/**
* @BeforeMethods({"enablePDOIntegration"})
* @Revs(100)
* @Iterations(5)
* @Iterations(15)
* @OutputTimeUnit("microseconds")
* @RetryThreshold(10.0)
*/
Expand All @@ -46,7 +46,7 @@ public function benchPDOOverhead()
/**
* @BeforeMethods({"enablePDOIntegrationWithDBM"})
* @Revs(100)
* @Iterations(5)
* @Iterations(15)
* @OutputTimeUnit("microseconds")
* @RetryThreshold(10.0)
*/
Expand Down
4 changes: 2 additions & 2 deletions tests/Benchmarks/Integrations/PHPRedisBench.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class PHPRedisBench
* @BeforeMethods({"disablePHPRedisIntegration"})
* @AfterMethods({"closeConnection"})
* @Revs(100)
* @Iterations(5)
* @Iterations(15)
* @OutputTimeUnit("microseconds")
* @RetryThreshold(10.0)
*/
Expand All @@ -28,7 +28,7 @@ public function benchRedisBaseline()
* @BeforeMethods({"enablePHPRedisIntegration"})
* @AfterMethods({"closeConnection"})
* @Revs(100)
* @Iterations(5)
* @Iterations(15)
* @OutputTimeUnit("microseconds")
* @RetryThreshold(10.0)
*/
Expand Down
Loading