Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase iterations of flaky benchmarks #2458

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Increase iterations of flaky benchmarks #2458

merged 4 commits into from
Jan 11, 2024

Conversation

PROFeNoM
Copy link
Contributor

Description

Three benchmarks appear to be flaky:

PHPRedisBench/benchRedisBaseline
ContextPropagationBench/benchExtractHeaders128Bit
PHPRedisBench/benchRedisOverhead

Following @ddyurchenko's recommendations, increase the iteration count of these subjects to 15.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM self-assigned this Jan 10, 2024
@PROFeNoM PROFeNoM requested a review from a team as a code owner January 10, 2024 14:28
@pr-commenter
Copy link

pr-commenter bot commented Jan 10, 2024

Benchmarks

Benchmark execution time: 2024-01-11 09:12:02

Comparing candidate commit 948f0f7 in PR branch alex/bench/flaky with baseline commit 4568c41 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 49 unstable metrics.

scenario:ContextPropagationBench/benchExtractHeaders128Bit

  • 🟩 execution_time [-1138.508ns; -394.825ns] or [-15.180%; -5.264%]

scenario:ContextPropagationBench/benchExtractTraceContext64Bit

  • 🟩 execution_time [-715.063ns; -184.937ns] or [-9.931%; -2.569%]

@PROFeNoM PROFeNoM merged commit fa486a8 into master Jan 11, 2024
3 checks passed
@PROFeNoM PROFeNoM deleted the alex/bench/flaky branch January 11, 2024 11:56
@github-actions github-actions bot added this to the 0.97.0 milestone Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants