Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Uninitialized access in ExecIntegration #2455

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix: Uninitialized access in ExecIntegration #2455

merged 1 commit into from
Jan 10, 2024

Conversation

PROFeNoM
Copy link
Contributor

Description

Stumbled onto this error while running the microbenchmarks with the debug logs.

Error thrown in ddtrace's closure defined at /app/candidate/src/Integrations/Integrations/Exec/ExecIntegration.php:197 for proc_close(): Typed property DDTrace\HookData::$data must not be accessed before initialization

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM self-assigned this Jan 10, 2024
@PROFeNoM PROFeNoM requested a review from a team as a code owner January 10, 2024 12:11
bwoebi
bwoebi approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple :-) Thanks!

@PROFeNoM PROFeNoM merged commit be1aac1 into master Jan 10, 2024
3 checks passed
@PROFeNoM PROFeNoM deleted the alex/fix/exec branch January 10, 2024 12:28
@github-actions github-actions bot added this to the 0.97.0 milestone Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwoebi bwoebi bwoebi approved these changes

Assignees

@PROFeNoM PROFeNoM

Labels
None yet
Projects
None yet
Milestone
0.97.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PROFeNoM @bwoebi