Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(profiler) prevent emitting empty profiles #2397

Merged
merged 5 commits into from
Jan 16, 2024
Merged

fix(profiler) prevent emitting empty profiles #2397

merged 5 commits into from
Jan 16, 2024

Conversation

realFlowControl
Copy link
Member

@realFlowControl realFlowControl commented Nov 29, 2023 •
edited
Loading

Description

This will make sure that empty profiles that we might send to the ddprof_time thread will be ignored. This should not happen anyway, but it happened in the past.

PROF-8749

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@pr-commenter
Copy link

pr-commenter bot commented Nov 29, 2023 •
edited
Loading

Benchmarks

Benchmark execution time: 2023-12-22 11:50:01

Comparing candidate commit bb260e2 in PR branch florian/prevent-emitting-profiles with baseline commit 96ce878 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 3 unstable metrics.

@realFlowControl realFlowControl force-pushed the florian/prevent-emitting-profiles branch from 143483c to 92f2fb7 Compare December 1, 2023 10:53
@github-actions github-actions bot added profiling Relates to the Continuous Profiler tracing labels Dec 1, 2023
@realFlowControl realFlowControl self-assigned this Dec 1, 2023
@realFlowControl realFlowControl force-pushed the florian/prevent-emitting-profiles branch from 92f2fb7 to 30ff7f3 Compare December 14, 2023 10:40
@realFlowControl realFlowControl force-pushed the florian/prevent-emitting-profiles branch from 6167902 to 8a1a52c Compare December 21, 2023 08:48
@realFlowControl realFlowControl added this to the 0.97.0 milestone Dec 21, 2023
@realFlowControl realFlowControl marked this pull request as ready for review December 21, 2023 08:49
@realFlowControl realFlowControl requested a review from a team as a code owner December 21, 2023 08:49
@realFlowControl realFlowControl changed the title fix(profiler) prevent emitting profiles fix(profiler) prevent emitting empty profiles Dec 21, 2023
morrisonlevi
morrisonlevi reviewed Dec 21, 2023
View reviewed changes
@github-actions github-actions bot removed this from the 0.97.0 milestone Dec 22, 2023
@morrisonlevi morrisonlevi merged commit 5334fb5 into master Jan 16, 2024
1 check passed
@morrisonlevi morrisonlevi deleted the florian/prevent-emitting-profiles branch January 16, 2024 22:01
@github-actions github-actions bot added this to the 0.97.0 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrisonlevi morrisonlevi morrisonlevi approved these changes

Assignees

@realFlowControl realFlowControl

Labels
profiling Relates to the Continuous Profiler tracing
Projects
None yet
Milestone
0.97.0
Development

Successfully merging this pull request may close these issues.
2 participants
@realFlowControl @morrisonlevi