test(profiling): with address sanitizer #2335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morrisonlevi
changed the title
|
Replaced by #2432. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will run the tests under
profiling/tests/phptwith the address sanitizer enabled. Note that it seems like our previous work to get clang 16 into the containers will unexpectedly pay off here, as the version of the OS sanitizers were too old to work with Rust nightly.State of PR: tests are passing locally with ad-hoc builds and configurations. Next I need to get it working with CI.
This work is the continuation and follow-up to these other PRs:
And is part of JIRA task PROF-8286.
Readiness checklist
Reviewer checklist