Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Ini file not created on install for specific pattern in PHP_INI_SCAN_DIR #2949

Closed
MitchelAnthony opened this issue Nov 13, 2024 · 2 comments
Labels
🐛 bug Something isn't working

Comments

@MitchelAnthony
Copy link

Bug report

The installer (datadog-setup.php) reads and uses, via this command, the additional php ini directory set through PHP_INI_SCAN_DIR to create a symlink to the 98-ddtrace.ini file. However, if the env var starts with the perfectly legal : (colon) character, the creation of the symlink fails. This is not communicated to the user, however, and the result is that the datadog agent is not loaded.

Example output (final lines only):

Created INI file ':/usr/local/etc/php/app.conf.d/98-ddtrace.ini'
Installation to 'php (/usr/local/bin/php)' was successful

The workaround we're currently using is to remove the colon from the env var just before running the installer and restoring it after the install, but it should probably be fixed at the source.

PHP version

8.3.13

Tracer or profiler version

master

Installed extensions

No response

Output of phpinfo()

No response

Upgrading from

No response

@MitchelAnthony MitchelAnthony added the 🐛 bug Something isn't working label Nov 13, 2024
@bwoebi
Copy link
Collaborator

bwoebi commented Nov 13, 2024

Hey @MitchelAnthony,

this was fixed in #2941 and will be working fine starting next release!

@bwoebi bwoebi closed this as completed Nov 13, 2024
@MitchelAnthony
Copy link
Author

I see! Thanks! For some reason it wasn't in the search results when I searched for a similar issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants