From f8180154e3f1b64acf51495c67d7cc6ad503745d Mon Sep 17 00:00:00 2001 From: Alexandre Choura Date: Thu, 4 Jan 2024 15:20:01 +0100 Subject: [PATCH] test: Remove flaky promises --- .../Guzzle/V6/GuzzleIntegrationTest.php | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/tests/Integrations/Guzzle/V6/GuzzleIntegrationTest.php b/tests/Integrations/Guzzle/V6/GuzzleIntegrationTest.php index fddc420b02..4758a85ad8 100644 --- a/tests/Integrations/Guzzle/V6/GuzzleIntegrationTest.php +++ b/tests/Integrations/Guzzle/V6/GuzzleIntegrationTest.php @@ -505,15 +505,11 @@ public function testMultiExec() $promises = [ $client->getAsync('https://google.wrong/'), //$client->getAsync('https://google.com/'), // Does a 301 Redirection to https://www.google.com/ ==> 2 spans - $client->getAsync(self::URL . '/redirect-to?url=' . self::URL . '/status/200'), + //$client->getAsync(self::URL . '/redirect-to?url=' . self::URL . '/status/200'), // too flaky $client->getAsync('https://google.still.wrong/'), ]; - try { - Utils::settle($promises)->wait(); - }catch (\Exception $e) { - // Ignore - echo $e->getMessage(); - } + + Utils::settle($promises)->wait(); $span->finish(); }); @@ -568,6 +564,7 @@ public function testMultiExec() $commonTags, 'error.stack' ]), + /* 'http://httpbin_integration/redirect-to' => SpanAssertion::exists('curl_exec', 'http:\/\/httpbin_integration\/redirect-to', false, 'host-httpbin_integration') ->withExactTags([ Tag::COMPONENT => 'curl', @@ -594,11 +591,12 @@ public function testMultiExec() 'curl.http_version' => '2', 'curl.protocol' => '2', 'curl.scheme' => 'HTTP', - 'curl.redirect_url' => 'https://www.google.com/' + 'curl.redirect_url' => 'http://httpbin_integration/status/200' ]) ->withExistingTagsNames([ $commonTags, ]), + */ 'https://google.still.wrong/' => SpanAssertion::exists('curl_exec', 'https://google.still.wrong/', true, 'host-google.still.wrong') ->withExactTags([ Tag::COMPONENT => 'curl',