test: Remove flaky promises

DataDog · Jan 4, 2024 · f818015 · f818015
1 parent 3c80691
commit f818015
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/tests/Integrations/Guzzle/V6/GuzzleIntegrationTest.php b/tests/Integrations/Guzzle/V6/GuzzleIntegrationTest.php
@@ -505,15 +505,11 @@ public function testMultiExec()
             $promises = [
                 $client->getAsync('https://google.wrong/'),
                 //$client->getAsync('https://google.com/'), // Does a 301 Redirection to https://www.google.com/ ==> 2 spans
-                $client->getAsync(self::URL . '/redirect-to?url=' . self::URL . '/status/200'),
+                //$client->getAsync(self::URL . '/redirect-to?url=' . self::URL . '/status/200'), // too flaky
                 $client->getAsync('https://google.still.wrong/'),
             ];
-            try {
-                Utils::settle($promises)->wait();
-            }catch (\Exception $e) {
-                // Ignore
-                echo $e->getMessage();
-            }
+
+            Utils::settle($promises)->wait();
 
             $span->finish();
         });
@@ -568,6 +564,7 @@ public function testMultiExec()
                     $commonTags,
                     'error.stack'
                 ]),
+            /*
             'http://httpbin_integration/redirect-to' => SpanAssertion::exists('curl_exec', 'http:\/\/httpbin_integration\/redirect-to', false, 'host-httpbin_integration')
                 ->withExactTags([
                     Tag::COMPONENT => 'curl',
@@ -594,11 +591,12 @@ public function testMultiExec()
                     'curl.http_version' => '2',
                     'curl.protocol' => '2',
                     'curl.scheme' => 'HTTP',
-                    'curl.redirect_url' => 'https://www.google.com/'
+                    'curl.redirect_url' => 'http://httpbin_integration/status/200'
                 ])
                 ->withExistingTagsNames([
                     $commonTags,
                 ]),
+            */
             'https://google.still.wrong/' => SpanAssertion::exists('curl_exec', 'https://google.still.wrong/', true, 'host-google.still.wrong')
                 ->withExactTags([
                     Tag::COMPONENT => 'curl',