feat(extension): add warning logs on unexpected cases

Signed-off-by: Alexandre Rulleau <[email protected]>
DataDog · Feb 20, 2025 · c8d4485 · c8d4485
1 parent 0086536
commit c8d4485
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/appsec/src/extension/commands_helpers.c b/appsec/src/extension/commands_helpers.c
@@ -592,6 +592,14 @@ static void dd_command_process_settings(mpack_node_t root)
         if (dd_string_equals_lc(
                 key_str, key_len, ZEND_STRL("auto_user_instrum"))) {
             dd_parse_user_collection_mode_rc(value_str, value_len);
+        } else {
+            if (!get_global_DD_APPSEC_TESTING()) {
+                mlog(dd_log_warning,
+                    "Failed to process user collection setting: "
+                    "unknown key %.*s",
+                    (int)key_len, key_str);
+            }
+            return;
         }
     }
 }

diff --git a/appsec/src/extension/user_tracking.c b/appsec/src/extension/user_tracking.c
@@ -201,6 +201,11 @@ void dd_parse_user_collection_mode_rc(
         _user_mode_rc = user_mode_anon;
     } else { // If the value is disabled or an unknown value, we disable user ID
              // collection
+        if (!get_global_DD_APPSEC_TESTING()) {
+            mlog_g(dd_log_warning,
+                "Unknown or disabled remote config user collection mode: %.*s",
+                (int)value_len, value);
+        }
         _user_mode_rc = user_mode_disabled;
     }
 }

diff --git a/appsec/src/helper/remote_config/listeners/asm_features_listener.hpp b/appsec/src/helper/remote_config/listeners/asm_features_listener.hpp
@@ -17,7 +17,7 @@ class asm_features_listener : public listener_base {
 public:
     explicit asm_features_listener(
         std::shared_ptr<dds::service_config> service_config)
-        : service_config_(std::move(service_config)) {};
+        : service_config_(std::move(service_config)){};
 
     void init() override;
     void on_update(const config &config) override;