fix: root span name in Slim V4 (#3020)

DataDog · Jan 7, 2025 · 7d37019 · 7d37019
1 parent cc11b8e
commit 7d37019
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/DDTrace/Integrations/Slim/SlimIntegration.php b/src/DDTrace/Integrations/Slim/SlimIntegration.php
@@ -34,6 +34,7 @@ function ($app) use ($integration, $appName) {
                 // Overwrite root span info
                 $rootSpan = \DDTrace\root_span();
                 $integration->addTraceAnalyticsIfEnabled($rootSpan);
+                $rootSpan->name = 'slim.request';
                 $rootSpan->service = $appName;
                 $rootSpan->meta[Tag::SPAN_KIND] = 'server';
                 $rootSpan->meta[Tag::COMPONENT] = SlimIntegration::NAME;
@@ -70,8 +71,6 @@ function ($errorMiddleware, $self, $args) use ($rootSpan, $integration) {
                 }
 
                 if ('3' === $majorVersion) {
-                    $rootSpan->name = 'slim.request';
-
                     // Hook into the router to extract the proper route name
                     \DDTrace\hook_method(
                         'Slim\\Router',

diff --git a/tests/Integrations/Slim/V4/CommonScenariosTest.php b/tests/Integrations/Slim/V4/CommonScenariosTest.php
@@ -104,7 +104,7 @@ public function provideSpecs()
             [
                 'A simple GET request returning a string' => [
                     SpanAssertion::build(
-                        'web.request',
+                        'slim.request',
                         'slim_test_app',
                         'web',
                         'GET /simple'
@@ -133,7 +133,7 @@ public function provideSpecs()
                 ],
                 'A simple GET request with a view' => [
                     SpanAssertion::build(
-                        'web.request',
+                        'slim.request',
                         'slim_test_app',
                         'web',
                         'GET /simple_view'
@@ -170,7 +170,7 @@ public function provideSpecs()
                 ],
                 'A GET request with an exception' => [
                     SpanAssertion::build(
-                        'web.request',
+                        'slim.request',
                         'slim_test_app',
                         'web',
                         'GET /error'
@@ -204,7 +204,7 @@ public function provideSpecs()
                 ],
                 'A GET request to a route with a parameter' => [
                     SpanAssertion::build(
-                        'web.request',
+                        'slim.request',
                         'slim_test_app',
                         'web',
                         'GET /parameterized/paramValue'