From 46f596dd61871db7c3e7f9d45eee991072047517 Mon Sep 17 00:00:00 2001 From: iamluc Date: Fri, 13 Dec 2024 11:40:25 +0100 Subject: [PATCH] fix compilation + fix on PHP < 7.4 --- ext/exception_serialize.c | 2 +- ext/live_debugger.c | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ext/exception_serialize.c b/ext/exception_serialize.c index 441b695902..874450d679 100644 --- a/ext/exception_serialize.c +++ b/ext/exception_serialize.c @@ -267,7 +267,7 @@ void ddtrace_create_capture_value(zval *zv, struct ddog_CaptureValue *value, con if (ce->type == ZEND_INTERNAL_CLASS) { #if PHP_VERSION_ID < 70400 if (is_temp) { - zend_array_release(ht); + zend_hash_next_index_insert_ptr(&DDTRACE_G(debugger_capture_ephemerals), ht); } #else zend_hash_next_index_insert_ptr(&DDTRACE_G(debugger_capture_ephemerals), ht); diff --git a/ext/live_debugger.c b/ext/live_debugger.c index 8965023006..194640cfe4 100644 --- a/ext/live_debugger.c +++ b/ext/live_debugger.c @@ -1296,7 +1296,12 @@ ddog_LiveDebuggerSetup ddtrace_live_debugger_setup = { static void dd_ht_ephemerals_dtor(void *pData) { HashTable *ht = *((HashTable **)pData); + +#if PHP_VERSION_ID < 70400 + zend_array_release(ht); +#else zend_release_properties(ht); +#endif } void ddtrace_live_debugger_minit(void) {