fix compilation + fix on PHP < 7.4

DataDog · Dec 19, 2024 · 46f596d · 46f596d
1 parent f7968ee
commit 46f596d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/ext/exception_serialize.c b/ext/exception_serialize.c
@@ -267,7 +267,7 @@ void ddtrace_create_capture_value(zval *zv, struct ddog_CaptureValue *value, con
             if (ce->type == ZEND_INTERNAL_CLASS) {
 #if PHP_VERSION_ID < 70400
                 if (is_temp) {
-                    zend_array_release(ht);
+                    zend_hash_next_index_insert_ptr(&DDTRACE_G(debugger_capture_ephemerals), ht);
                 }
 #else
                 zend_hash_next_index_insert_ptr(&DDTRACE_G(debugger_capture_ephemerals), ht);

diff --git a/ext/live_debugger.c b/ext/live_debugger.c
@@ -1296,7 +1296,12 @@ ddog_LiveDebuggerSetup ddtrace_live_debugger_setup = {
 
 static void dd_ht_ephemerals_dtor(void *pData) {
     HashTable *ht = *((HashTable **)pData);
+
+#if PHP_VERSION_ID < 70400
+    zend_array_release(ht);
+#else
     zend_release_properties(ht);
+#endif
 }
 
 void ddtrace_live_debugger_minit(void) {