Add format to logging messages

DataDog · Feb 20, 2025 · 361f307 · 361f307
1 parent 1bf12b2
commit 361f307
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/appsec/src/extension/backtrace.c b/appsec/src/extension/backtrace.c
@@ -245,7 +245,9 @@ bool dd_report_exploit_backtrace(zend_string *nullable id)
         array_init(meta_struct);
     } else if (Z_TYPE_P(meta_struct) != IS_ARRAY) {
         if (!get_global_DD_APPSEC_TESTING()) {
-            mlog(dd_log_trace, "Field meta_struct is not an array");
+            mlog(dd_log_trace,
+                "Field 'meta_struct' is of type '%d', expected 'array'",
+                Z_TYPE_P(meta_struct));
         }
         return false;
     }
@@ -262,15 +264,18 @@ bool dd_report_exploit_backtrace(zend_string *nullable id)
         mlog(dd_log_trace, "Backtrace stack created");
     } else if (Z_TYPE_P(dd_stack) != IS_ARRAY) {
         if (!get_global_DD_APPSEC_TESTING()) {
-            mlog(dd_log_trace, "Field stack is not an array");
+            mlog(dd_log_trace,
+                "Field 'stack' is of type '%d', expected 'array'",
+                Z_TYPE_P(dd_stack));
         }
         return false;
     } else {
         exploit = zend_hash_find(Z_ARR_P(dd_stack), _exploit_key);
     }
 
     if (Z_TYPE_P(exploit) != IS_ARRAY) {
-        mlog(dd_log_trace, "Field exploit is not an array");
+        mlog(dd_log_trace, "Field 'exploit' is of type '%d', expected 'array'",
+            Z_TYPE_P(exploit));
         return false;
     }