try again

DataDog · Nov 1, 2024 · 2c8c58f · 2c8c58f
1 parent 0f2e7dc
commit 2c8c58f
Showing 1 changed file with 0 additions and 8 deletions.
diff --git a/ext/ddtrace.c b/ext/ddtrace.c
@@ -1115,14 +1115,6 @@ static zval *ddtrace_root_span_data_write(zend_object *object, zend_string *memb
         if (ddtrace_span_is_entrypoint_root(&span->span) && !zend_is_identical(&span->property_service, value)) {
             root_span_data_changed = true;
         }
-        // As per unified service tagging spec if a span is created with a service name different from the global
-        // service name it will not inherit the global version value
-        if (!ddtrace_span_is_entrypoint_root(&span->span) && !zend_is_identical(&span->property_service, value)) {
-            // Free the old value of property_version
-            zval_ptr_dtor(&span->property_version);
-            // Set property_version to empty string
-            ZVAL_EMPTY_STRING(&span->property_version);
-        }
         cache_slot = NULL;
     } else if (zend_string_equals_literal(prop_name, "env")) {
         if (ddtrace_span_is_entrypoint_root(&span->span) && !zend_is_identical(&span->property_env, value)) {