From 196c7f271e33a6d4df5ac65e20125955f67ef5fc Mon Sep 17 00:00:00 2001
From: Luc Vieillescazes <luc@vieillescazes.net>
Date: Fri, 6 Dec 2024 08:46:29 +0100
Subject: [PATCH] [loader] Exit if execv failed (#2983)

* Exit if execv failed

* Log execv error
---
 loader/dd_library_loader.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/loader/dd_library_loader.c b/loader/dd_library_loader.c
index 39bc258ae6..0a3365c493 100644
--- a/loader/dd_library_loader.c
+++ b/loader/dd_library_loader.c
@@ -8,6 +8,7 @@
 #include <php.h>
 #include <php_ini.h>
 #include <stdbool.h>
+#include <errno.h>
 #include <main/SAPI.h>
 #include <ext/standard/basic_functions.h>
 
@@ -316,9 +317,13 @@ static void ddloader_telemetryf(telemetry_reason reason, const char *format, ...
     snprintf(payload, sizeof(payload), template, runtime_version, runtime_version, tracer_version, loader_pid, points);
 
     char *argv[] = {telemetry_forwarder_path, "library_entrypoint", payload, NULL};
-    if (execv(telemetry_forwarder_path, argv)) {
-        LOG(ERROR, "Telemetry: cannot execv")
-    }
+
+    execv(telemetry_forwarder_path, argv);
+    LOG(ERROR, "Telemetry: cannot execv: %s", strerror(errno))
+
+    // If execv failed, exit immediately
+    // Return 127 for the most likely case of a missing file
+    exit(127);
 }
 
 static char *ddloader_find_ext_path(const char *ext_dir, const char *ext_name, int module_api, bool is_zts, bool is_debug) {