Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http.request resource name only showing request method #4936

Open
eidsvold opened this issue Nov 25, 2024 · 3 comments
Open

http.request resource name only showing request method #4936

eidsvold opened this issue Nov 25, 2024 · 3 comments

Comments

@eidsvold
Copy link

Hi,

We are using Container-Based APM on our Kubernetes cluster. We have the agent running in the cluster and dd-trace is enabled by annotations and environment variables, not via application code. It works great.

We have a Fastify API that makes multiple outgoing HTTP requests using axios. The issue we have is that the http.request resource names are named only by the HTTP method. We are not able to see metrics for different outgoing requests as they are all named GET or POST.

Image

Is it possible to include the request URL in the resource name? The dd-trace-java does this, as we have this granularity for our Java APIs.

For incoming requests, fastify.request names the resources by request method and URL. We would love the same for outgoing requests.

node: 20.10
typescript: 5.7.2
fastify: 5.1.0
axios: 1.6.8
K8s: admission.datadoghq.com/js-lib.version: v5.27.1

@robin-thomas
Copy link

robin-thomas commented Dec 6, 2024

@eidsvold See whether v5.28.0 is working for you. I noticed it broke in v5.25.0 for fastify and then after upgrading to v5.28.0, its working for me.

Could be related to #4942. Not sure.

@robinth91
Copy link

The issue is back after upgrading to v5.30.0

@dkeller-sondermind
Copy link

dkeller-sondermind commented Feb 5, 2025

Hi just chiming in here to add, we were also experiencing similar issues where dd-trace was not picking up express.request resource traces after upgrading to 5.30.0. Downgrading to 5.28.0 resolved the issue. We have a simple index.ts entrypoint with dd-trace as the first import, followed by express and all other dependencies.

Node 22 (node:22-alpine docker image)
Typescript 5.7.2
Express 4.21.2

Unverified, but quickly glancing through changelog, perhaps this might be caused by the hook registration order changes in #4913 ? Or the router hooks added in packages/datadog-instrumentations/src/router.js (Released in 5.29.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants