OpenTelemetry span builder uses span name as resource name instead of operation name.

[tmccombs]

See

dd-trace-java/dd-java-agent/agent-otel/otel-shim/src/main/java/datadog/opentelemetry/shim/trace/OtelTracer.java

Line 24 in 51d3cee

this.tracer.buildSpan(INSTRUMENTATION_NAME, SPAN_KIND_INTERNAL).withResourceName(spanName);

Unlike in the opentracing tracer we pass SPAN_KIND_INTERNAL as the operationName to the delegate tracer, instead of the span name passed in to spanBuilder. Then passes the spanName as the resource name.

Is there a reason for this inconsistency?

Or was the intent that SPAN_KIND_INTERNAL was mean to be the span kind, but was actually passed as the operation name?

[dougqh]

OpenTelemetry doesn't really have an equivalent to Datadog's operation name.
OpenTelemetry's span name is closest to Datadog's resource name.

@PerfectSlayer can probably provide a bit more detail.

[PerfectSlayer]

Hi @tmccombs

As Doug said, there is no operation name concept from OTel.
So yes, it is intended to set SPAN_KIND_INTERNAL at span creation.
It is used as a maker to later check if you don’t update it (using the Datadog Tracing API).
If you don’t, we will try to compute a better operation name from heuristics at the span end:

dd-trace-java/dd-java-agent/agent-otel/otel-shim/src/main/java/datadog/opentelemetry/shim/trace/OtelSpan.java

Lines 118 to 122 in 4cdcb05

	public void end() {
	this.recording = false;
	applyNamingConvention(this.delegate);
	this.delegate.finish();
	}

dd-trace-java/dd-java-agent/agent-otel/otel-shim/src/main/java/datadog/opentelemetry/shim/trace/OtelConventions.java

Lines 121 to 126 in a248438

	public static void applyNamingConvention(AgentSpan span) {
	// Check if span operation name is unchanged from its default value
	if (span.getOperationName() == SPAN_KIND_INTERNAL) {
	span.setOperationName(computeOperationName(span).toLowerCase(ROOT));
	}
	}

I hope that clarifies the naming behavior
Best,
Bruce

[tmccombs]

Ah! that explains why I was seeing the operation name as "client.request" instead of "internal".

For context, I tried migrating some code from the OpenTracing API to the OpenTelemetry API, and expected the span name to behave similarly, but the operation name changed.