Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NovaCustom NV4x (coreboot + heads) v0.9.0 - release preparation - firmware #580

Closed
3 tasks
macpijan opened this issue Nov 8, 2023 · 8 comments
Closed
3 tasks
Assignees
Labels
novacustom_nv4x_adl NovaCustom NV4xPZ (12th Gen)

Comments

@macpijan
Copy link
Contributor

macpijan commented Nov 8, 2023

Dasharo version (if applicable)

Dasharo variant (if applicable)

Affected component(s) or functionality (if applicable)

Brief summary

Additional context

@tlaurion
Copy link

tlaurion commented Dec 17, 2023

@macpijan

See:


Opinions needed :

Goal would be to not end up with multiple nv41/ns50 under Heads, where rebranding should be applied in forks.


~Fixed:

Nk 2.4 firmware release based on Heads should now be possible. No idea of when and how, things have been messy for retracted 2.3 and people use 2.1/2.2 for the moment. Nk not following your coreboot fork upstream under Heads either. Duplicates of bug reports everywhere and I do not own the hardware. Yet? But I receive and manage bug reports. Above my pay grade.

PS: in future please tag @tlaurion so I receive notifications.


Discussion :
How a user would update both EC and firmware that needs to be upgraded together it seems? Will heads also build EC and pack it under zip for upgrade?

@jans23
Copy link

jans23 commented Dec 18, 2023

This issue is related to NovaCustom's device and Dasharo firmware. I don't see how this is related to Nitrokey's firmware. Maybe it would help to keep these two things separate.

@pietrushnic
Copy link

PS: in future please tag @tlaurion so I receive notifications.

@tlaurion, we didn't tag you because we had no intention of bothering you with our preparation. The ball is on our side. We know how to reach out to you if we need your attention.

I agree with @jans23 that your message @tlaurion mixes issues. We should split those as commits, one logical issue per ticket. Under the Dasharo organization, I would be fine to discuss Dasharo-related issues and upstream-related stuff, but I would like to avoid commenting on other forks. Dasharo should be a place for cooperation, not competition.

Please give us some time to jump on this topic. The current release target for Dasharo (coreboot+Heads) v0.9.0 for Novacustom NV4x is 25.01.2024. Please note that there is no plan to support NS5x.

@BeataZdunczyk BeataZdunczyk added the novacustom_nv4x_adl NovaCustom NV4xPZ (12th Gen) label Jan 10, 2024
@mkopec
Copy link
Member

mkopec commented Jan 22, 2024

How a user would update both EC and firmware that needs to be upgraded together it seems? Will heads also build EC and pack it under zip for upgrade?

For the EC update issue, I propose we follow a similar approach as ChromeOS devices for EC updates, where the EC firmware is updated by coreboot if coreboot finds a version mismatch. This solves a couple of problems:

  • Single binary to distribute, download, verify and flash
  • Can't mismatch coreboot and EC versions
  • No need to distribute additional tool for updates
  • EC FW is measured and verified by coreboot
  • EC update interface can be locked down before passing control to payload, so nobody can flash malicious FW to it

This basically requires porting the EC update protocol from system76_ectool to coreboot, I got some basics working and running on Clevo NV40MZ: Dasharo/coreboot#456

I've tested comparing version and board model so far, need to test reading FW tomorrow, once reading is working well, writing should be easy to add.

Then the EC buildsystem can probably be integrated with coreboot's for easier building.

Related issue: #660

@mkopec
Copy link
Member

mkopec commented Feb 12, 2024

For the EC update we went with DTS for this release. EC FW sync may be explored at some point in a future release.

The code in Dasharo/heads#2 can now be built. With @miczyg1 's help I fixed an issue where the platform wouldn't boot after rebasing coreboot on latest Dasharo code, and centered the logo in the middle of the screen, without scaling.

@mkopec
Copy link
Member

mkopec commented Feb 16, 2024

Resolved problems with building binaries in CI (in freshly cloned repos in general): linuxboot/heads#1614

Binaries can now be downloaded from CI: https://app.circleci.com/pipelines/github/Dasharo/heads/88/workflows/a0553e6d-02f3-41e8-b170-96206da7a400/jobs/1936/artifacts

@mkopec
Copy link
Member

mkopec commented Feb 22, 2024

I've tagged release v0.9.0: https://github.com/Dasharo/heads/releases/tag/novacustom_nv4x_adl_v0.9.0 - same rev as what we've tested previously. Binaries have been uploaded to cloud in preparation for DES release.

@BeataZdunczyk
Copy link
Member

Closing this issue as the release notes has been published: https://docs.dasharo.com/variants/novacustom_nv4x_adl/heads/#v090-2024-02-29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
novacustom_nv4x_adl NovaCustom NV4xPZ (12th Gen)
Projects
None yet
Development

No branches or pull requests

6 participants