Skip to content
This repository has been archived by the owner on Feb 18, 2022. It is now read-only.

Incorrect settable_type value upon migration #29

Open
rudolfbruder opened this issue Dec 28, 2021 · 8 comments
Open

Incorrect settable_type value upon migration #29

rudolfbruder opened this issue Dec 28, 2021 · 8 comments

Comments

@rudolfbruder
Copy link

rudolfbruder commented Dec 28, 2021

Hi,

I am facing issue that when I run the php artisan settings:migrate command my database gets nicely seeded how ever the models do not include backslashes there for $user->settings does not work.

However I found out that if I run $user->settings()->initialize() it will recreate all of the settings with proper settable_type including backslashes. Here is a screenshot:

image

I am able to solve this issue by editing the fillSettings method in Pipes\CreateNewMetadata.php file like this:
image
However I am not sure if it is the proper approach.

Can someone please help me why is this behavior here?

@rudolfbruder
Copy link
Author

Unfortunately the merge request (Issue 21) has not solved my problem. I tried it on windows as well as on mac and still when i run php artisan settings:migrate the settable_type is inserted without backslashes like this: AppModelsUserUser

Any advice please? Am I doing something wrong?

Thanks!

@divdax
Copy link

divdax commented Jan 11, 2022

Same issue here.

@rudolfbruder
Copy link
Author

@divdax I had to create a fork until this gets fixed :)

@DarkGhostHunter
Copy link
Owner

DarkGhostHunter commented Jan 11, 2022

Can someone test this works on master?

My old PC went to hell.

@rudolfbruder
Copy link
Author

Nah did not work after your last approved pull request. Still using my fork.

@rudolfbruder
Copy link
Author

rudolfbruder commented Feb 7, 2022

@DarkGhostHunter Hey, can we do something about this? Should raise a PR?

@DarkGhostHunter
Copy link
Owner

@DarkGhostHunter Hey, can we do something about this? Should raise a PR?

Pleas, hands full.

@rudolfbruder
Copy link
Author

rudolfbruder commented Feb 15, 2022

Raised #35 for this one @DarkGhostHunter. Can you please take a look?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants