From 2d8113ee6278878615ba2a509059999274540e30 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Luthi?= Date: Tue, 13 Jun 2023 15:45:30 +0200 Subject: [PATCH 1/2] Re-enable Firebird tests (Issue178_Firebird) --- .../Dapper.Tests.Performance/Dapper.Tests.Performance.csproj | 2 +- tests/Dapper.Tests/Dapper.Tests.csproj | 2 +- tests/Dapper.Tests/Providers/FirebirdTests.cs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/benchmarks/Dapper.Tests.Performance/Dapper.Tests.Performance.csproj b/benchmarks/Dapper.Tests.Performance/Dapper.Tests.Performance.csproj index 914104e50..cc8e8c22d 100644 --- a/benchmarks/Dapper.Tests.Performance/Dapper.Tests.Performance.csproj +++ b/benchmarks/Dapper.Tests.Performance/Dapper.Tests.Performance.csproj @@ -14,7 +14,7 @@ - + diff --git a/tests/Dapper.Tests/Dapper.Tests.csproj b/tests/Dapper.Tests/Dapper.Tests.csproj index 35af8a509..667814dd7 100644 --- a/tests/Dapper.Tests/Dapper.Tests.csproj +++ b/tests/Dapper.Tests/Dapper.Tests.csproj @@ -14,7 +14,7 @@ - + diff --git a/tests/Dapper.Tests/Providers/FirebirdTests.cs b/tests/Dapper.Tests/Providers/FirebirdTests.cs index ae383b7fb..7aa689404 100644 --- a/tests/Dapper.Tests/Providers/FirebirdTests.cs +++ b/tests/Dapper.Tests/Providers/FirebirdTests.cs @@ -15,7 +15,7 @@ public class FirebirdTests : TestBase { private FbConnection GetOpenFirebirdConnection() => (FbConnection)Provider.GetOpenConnection(); - [Fact(Skip = "Bug in Firebird; a PR to fix it has been submitted")] + [Fact] public void Issue178_Firebird() { using (var connection = GetOpenFirebirdConnection()) From 225c3a2f775755fddef2f97fd3545c36d4c91e09 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Luthi?= Date: Tue, 13 Jun 2023 16:17:06 +0200 Subject: [PATCH 2/2] Run Firebird in a docker container for the Firebird tests on AppVeyor --- appveyor.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/appveyor.yml b/appveyor.yml index 122b20fab..55c7f8764 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -35,6 +35,7 @@ init: - git config --global core.autocrlf input - SET PATH=%POSTGRES_PATH%\bin;%MYSQL_PATH%\bin;%PATH% - net start MSSQL$SQL2019 + - docker run -d -p 3050:3050 --name Dapper.Tests.Firebird -e FIREBIRD_DATABASE=database -e ISC_PASSWORD=masterkey jacobalberty/firebird nuget: disable_publish_on_pr: true