Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can add a heart icon to identify a song added to favorite and add a favorite button for mini player ?? #26

Open
chamudha opened this issue May 3, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@chamudha
Copy link

chamudha commented May 3, 2024

Picsart_24-05-01_22-38-26-640.jpg

Like in this image

@DanielSevillano DanielSevillano added the enhancement New feature or request label May 9, 2024
@DanielSevillano
Copy link
Owner

I like the heart icon next to the author, I'll try to implement it.

I don't know if adding another button to the mini player is a good idea. It isn't an essential action and it would leave less space for the title and artist.

@archit9169
Copy link

I like the heart icon next to the author, I'll try to implement it.

I don't know if adding another button to the mini player is a good idea. It isn't an essential action and it would leave less space for the title and artist.

I think what he meant was to add a like button to the mini pkayer for a quick like without opening the whole player page. Perhaps a gesture can be implemented on swipe right or swipe left to either dismiss the player or add to like.

@chamudha
Copy link
Author

I didn't mean that,Don't change swipe options in mini player.

@archit9169
Copy link

archit9169 commented May 20, 2024

I didn't mean that,Don't change swipe options in mini player.

No, that part was my addition to the ongoing conversation.

I think he understood what you wanted, but is concerned that it might increase clutter on the mini player. So, just suggested another option/alternative that might work.

@DanielSevillano
Copy link
Owner

Perhaps a gesture can be implemented on swipe right or swipe left to either dismiss the player or add to like.

Unfortunately, every swipe gesture is currently used for the essential actions (open and dismiss player, go to previous or next song). I suppose that a double tap could work, but it would need a visual indicator to let users know if a song is already in favorites or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants