Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chart/redis-ha]support configuration for redis container command parameter #254

Open
GDegrove opened this issue Jun 5, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@GDegrove
Copy link

GDegrove commented Jun 5, 2023

Is your feature request related to a problem? Please describe.

I'm trying to deploy redis-ha using redis-stack-server as the image.

From what I can see, the current helm chart only start the container with redis-server. However, when using the redis-stack-server you want to start the contianer with /entrypoint.sh (don't know why the startup script is name entrypoint though...) or using the redis-stack-server.

Describe the solution you'd like

Add a configuration for the helm chart to contain a way to override/configure the command. Instead of using the hard-coded edis-server, we may want to let user chose.
This would allow a developer to easily change the configuration of the helm chart without spending too much time on making sure their image is compatible with it.

Describe alternatives you've considered

  • make a change in the upstream image
  • download module with an init container
@GDegrove GDegrove added the enhancement New feature or request label Jun 5, 2023
@GDegrove
Copy link
Author

GDegrove commented Jun 5, 2023

seems that would be resolved by #238

@DandyDeveloper
Copy link
Owner

Yes. #238 would do this, it was neglected. I'll re-review to see if this is definitely fit for purpose and try to get this merged in.

@DandyDeveloper DandyDeveloper self-assigned this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants