-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
모든 URL 중앙화 #197
Merged
Merged
모든 URL 중앙화 #197
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
import { html, css } from "../html-css-utils.js"; | ||
import { APPLICATION_URL } from "../data.js"; | ||
import { APPLICATION_URL, DISCORD_URL, PROJECT_URL } from "../data.js"; | ||
|
||
class StepsSection extends HTMLElement { | ||
constructor() { | ||
|
@@ -55,9 +55,7 @@ class StepsSection extends HTMLElement { | |
<p slot="content"> | ||
답안 제출과 확인은 깃허브를 통해 이루어져요. 스터디 전체 | ||
진행상황을 알고 싶다면 | ||
<ds-step-text-link | ||
link="https://github.com/orgs/DaleStudy/projects/1" | ||
> | ||
<ds-step-text-link link="${PROJECT_URL}"> | ||
프로젝트 보드 | ||
</ds-step-text-link> | ||
를 통해 파악할 수 있어요. | ||
|
@@ -66,7 +64,7 @@ class StepsSection extends HTMLElement { | |
<ds-step step="3" icon-src="images/icon_step3.png"> | ||
<p slot="content"> | ||
매주 스터디 멤버들끼리 | ||
<ds-step-text-link link="https://discord.com/invite/6TwzdnW6ze"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 디스코드 URL이 여러 군데 있어도 이제는 동일하겠지 생각하고 있었는데 아니었네요. 😅 한 곳으로 빼기 잘 했다는 생각이 들었습니다. 코드 편집기의 모두 찾기 기능으로 일괄 바꿔치기 했더라면 이 놈은 놓칠뻔했습니다. |
||
<ds-step-text-link link="${DISCORD_URL}"> | ||
디스코드 | ||
</ds-step-text-link> | ||
에서 간단한 모임을 가져요. 멤버 간의 친밀감도 쌓고 해외 취업 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,12 @@ | ||
export const APPLICATION_URL = | ||
"https://github.com/DaleStudy/leetcode-study/discussions/209"; | ||
export const DISCORD_URL = "https://discord.gg/6TwzdnW6ze"; | ||
export const PROJECT_URL = "https://github.com/orgs/DaleStudy/projects/1"; | ||
export const CONTRIBUTING_URL = | ||
"https://github.com/DaleStudy/leetcode-study/blob/main/CONTRIBUTING.md"; | ||
export const FAQ_URL = | ||
"https://github.com/DaleStudy/leetcode-study/discussions/54"; | ||
export const ALGO_DALE_URL = "https://www.algodale.com/"; | ||
export const LINKED_IN_URL = "https://www.linkedin.com/in/daleseo/"; | ||
export const GITHUB_URL = "https://github.com/DaleStudy/leetcode-study"; | ||
export const YOUTUBE_URL = "https://www.youtube.com/@DaleSeo"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
본 PR의 목표와는 관계가 없지만 파일 이름이 컴포넌트 명과 일치하지 않아서 정정하였습니다.