Skip to content

Commit 3a6767c

Browse files
DaleSeoDaleSeo
authored
Merge pull request #197 from DaleStudy/centralize-other-urls
๋ชจ๋“  URL ์ค‘์•™ํ™”
2 parents a30301e + 12bde93 commit 3a6767c

File tree

9 files changed

+70
-67
lines changed

9 files changed

+70
-67
lines changed

โ€Žcomponents/code-review-section.js

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { css, html } from "../html-css-utils.js";
2+
import { DISCORD_URL } from "../data.js";
23

34
class CodeReviewSection extends HTMLElement {
45
constructor() {
@@ -71,19 +72,25 @@ class CodeReviewSection extends HTMLElement {
7172
}
7273
}
7374
`;
74-
}
75-
75+
}
7676

7777
createHtml() {
7878
return html`
7979
<section>
8080
<aside>
81-
<slot name="image"></slot>
81+
<ds-image
82+
src="images/review.png"
83+
alt="review"
84+
width="100%"
85+
height="auto"
86+
></ds-image>
8287
</aside>
8388
8489
<div class="hero">
85-
<slot name="heading"></slot>
86-
<slot name="button"></slot>
90+
<ds-hero> ์ฝ”๋“œ๋ฆฌ๋ทฐ๋ฅผ ํ†ตํ•ด ์ƒˆ๋กœ์šด ๊ด€์ ์„ ๋ฐฐ์šธ ์ˆ˜ ์žˆ์–ด์š” </ds-hero>
91+
<ds-button-link size="big" variant="primary" href="${DISCORD_URL}">
92+
๋””์Šค์ฝ”๋“œ ์ฐธ์—ฌํ•˜๊ธฐ
93+
</ds-button-link>
8794
</div>
8895
</section>
8996
`;

โ€Žcomponents/footer-link-list.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { css, html } from "../html-css-utils.js";
2-
import { APPLICATION_URL } from "../data.js";
2+
import { APPLICATION_URL, CONTRIBUTING_URL, FAQ_URL } from "../data.js";
33

44
class FooterLinkList extends HTMLElement {
55
constructor() {
@@ -70,7 +70,7 @@ class FooterLinkList extends HTMLElement {
7070
return html`<ul>
7171
<li>
7272
<a
73-
href="https://github.com/DaleStudy/leetcode-study/discussions/54"
73+
href="${FAQ_URL}"
7474
target="_blank"
7575
aria-label="Read the FAQ discussion on Algorithm study group"
7676
>
@@ -90,7 +90,7 @@ class FooterLinkList extends HTMLElement {
9090
9191
<li>
9292
<a
93-
href="https://github.com/DaleStudy/leetcode-study/blob/main/CONTRIBUTING.md"
93+
href="${CONTRIBUTING_URL}"
9494
target="_blank"
9595
aria-label="Read the contributing guide for the Algorithm study group"
9696
>

โ€Žcomponents/header.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { css, html } from "../html-css-utils.js";
2+
import { DISCORD_URL } from "../data.js";
23

34
class Header extends HTMLElement {
45
constructor() {
@@ -288,10 +289,7 @@ class Header extends HTMLElement {
288289
<ds-button-link href="#steps-section" size="small" variant="ghost"
289290
>์ฐธ์—ฌ๋ฐฉ๋ฒ• ์•ˆ๋‚ด</ds-button-link
290291
>
291-
<ds-button-link
292-
href="https://discord.gg/6TwzdnW6ze"
293-
size="small"
294-
variant="primary"
292+
<ds-button-link href="${DISCORD_URL}" size="small" variant="primary"
295293
>๋””์Šค์ฝ”๋“œ ์ฐธ์—ฌํ•˜๊ธฐ</ds-button-link
296294
>
297295
</div>

โ€Žcomponents/icon-link-list.js

Lines changed: 26 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,10 @@
11
import { css, html } from "../html-css-utils.js";
2+
import {
3+
ALGO_DALE_URL,
4+
GITHUB_URL,
5+
LINKED_IN_URL,
6+
YOUTUBE_URL,
7+
} from "../data.js";
28

39
class IconLinkList extends HTMLElement {
410
constructor() {
@@ -58,7 +64,11 @@ class IconLinkList extends HTMLElement {
5864

5965
createHtml() {
6066
return html`<section>
61-
<a href="https://www.algodale.com/" target="_blank" aria-label="Visit the Algodale website">
67+
<a
68+
href="${ALGO_DALE_URL}"
69+
target="_blank"
70+
aria-label="Visit the Algodale website"
71+
>
6272
<svg
6373
width="24"
6474
height="24"
@@ -73,7 +83,11 @@ class IconLinkList extends HTMLElement {
7383
</svg>
7484
</a>
7585
76-
<a href="https://www.linkedin.com/in/daleseo/" target="_blank" aria-label="Visit Dale's LinkedIn profile">
86+
<a
87+
href="${LINKED_IN_URL}"
88+
target="_blank"
89+
aria-label="Visit Dale's LinkedIn profile"
90+
>
7791
<svg
7892
width="24"
7993
height="24"
@@ -88,7 +102,11 @@ class IconLinkList extends HTMLElement {
88102
</svg>
89103
</a>
90104
91-
<a href="https://github.com/DaleStudy/leetcode-study" target="_blank" aria-label="Visit the Algorithm study group's GitHub repository">
105+
<a
106+
href="${GITHUB_URL}"
107+
target="_blank"
108+
aria-label="Visit the Algorithm study group's GitHub repository"
109+
>
92110
<svg
93111
width="25"
94112
height="24"
@@ -103,7 +121,11 @@ class IconLinkList extends HTMLElement {
103121
</svg>
104122
</a>
105123
106-
<a href="https://www.youtube.com/@DaleSeo" target="_blank" aria-label="Visit Dale's YouTube channel">
124+
<a
125+
href="${YOUTUBE_URL}"
126+
target="_blank"
127+
aria-label="Visit Dale's YouTube channel"
128+
>
107129
<svg
108130
width="25"
109131
height="18"

โ€Žcomponents/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ import "./intro-section.js";
1010
import "./language-section.js";
1111
import "./participant-review-section.js";
1212
import "./participant-review.js";
13-
import "./step-section.js";
13+
import "./steps-section.js";
1414
import "./step.js";

โ€Žcomponents/intro-section.js

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { css, html } from "../html-css-utils.js";
2+
import { DISCORD_URL } from "../data.js";
23

34
class IntroSection extends HTMLElement {
45
constructor() {
@@ -87,12 +88,19 @@ class IntroSection extends HTMLElement {
8788
return html`
8889
<section>
8990
<aside>
90-
<slot name="image"></slot>
91+
<ds-image
92+
src="images/roadmap.png"
93+
alt="roadmap"
94+
width="100%"
95+
height="auto"
96+
></ds-image>
9197
</aside>
9298
9399
<article>
94-
<slot name="heading"></slot>
95-
<slot name="button"></slot>
100+
<ds-hero> ํ•ด์™ธ์ทจ์—…์„ ์œ„ํ•œ ์ปค๋ฎค๋‹ˆํ‹ฐ ๊ธฐ๋ฐ˜ ์•Œ๊ณ ๋ฆฌ์ฆ˜ ์Šคํ„ฐ๋”” </ds-hero>
101+
<ds-button-link size="big" variant="primary" href="${DISCORD_URL}">
102+
๋””์Šค์ฝ”๋“œ ์ฐธ์—ฌํ•˜๊ธฐ
103+
</ds-button-link>
96104
</article>
97105
</section>
98106
`;

โ€Žcomponents/step-section.js renamed to โ€Žcomponents/steps-section.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { html, css } from "../html-css-utils.js";
2-
import { APPLICATION_URL } from "../data.js";
2+
import { APPLICATION_URL, DISCORD_URL, PROJECT_URL } from "../data.js";
33

44
class StepsSection extends HTMLElement {
55
constructor() {
@@ -55,9 +55,7 @@ class StepsSection extends HTMLElement {
5555
<p slot="content">
5656
๋‹ต์•ˆ ์ œ์ถœ๊ณผ ํ™•์ธ์€ ๊นƒํ—ˆ๋ธŒ๋ฅผ ํ†ตํ•ด ์ด๋ฃจ์–ด์ ธ์š”. ์Šคํ„ฐ๋”” ์ „์ฒด
5757
์ง„ํ–‰์ƒํ™ฉ์„ ์•Œ๊ณ  ์‹ถ๋‹ค๋ฉด
58-
<ds-step-text-link
59-
link="https://github.com/orgs/DaleStudy/projects/1"
60-
>
58+
<ds-step-text-link link="${PROJECT_URL}">
6159
ํ”„๋กœ์ ํŠธ ๋ณด๋“œ
6260
</ds-step-text-link>
6361
๋ฅผ ํ†ตํ•ด ํŒŒ์•…ํ•  ์ˆ˜ ์žˆ์–ด์š”.
@@ -66,7 +64,7 @@ class StepsSection extends HTMLElement {
6664
<ds-step step="3" icon-src="images/icon_step3.png">
6765
<p slot="content">
6866
๋งค์ฃผ ์Šคํ„ฐ๋”” ๋ฉค๋ฒ„๋“ค๋ผ๋ฆฌ
69-
<ds-step-text-link link="https://discord.com/invite/6TwzdnW6ze">
67+
<ds-step-text-link link="${DISCORD_URL}">
7068
๋””์Šค์ฝ”๋“œ
7169
</ds-step-text-link>
7270
์—์„œ ๊ฐ„๋‹จํ•œ ๋ชจ์ž„์„ ๊ฐ€์ ธ์š”. ๋ฉค๋ฒ„ ๊ฐ„์˜ ์นœ๋ฐ€๊ฐ๋„ ์Œ“๊ณ  ํ•ด์™ธ ์ทจ์—…

โ€Ždata.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,12 @@
11
export const APPLICATION_URL =
22
"https://github.com/DaleStudy/leetcode-study/discussions/209";
3+
export const DISCORD_URL = "https://discord.gg/6TwzdnW6ze";
4+
export const PROJECT_URL = "https://github.com/orgs/DaleStudy/projects/1";
5+
export const CONTRIBUTING_URL =
6+
"https://github.com/DaleStudy/leetcode-study/blob/main/CONTRIBUTING.md";
7+
export const FAQ_URL =
8+
"https://github.com/DaleStudy/leetcode-study/discussions/54";
9+
export const ALGO_DALE_URL = "https://www.algodale.com/";
10+
export const LINKED_IN_URL = "https://www.linkedin.com/in/daleseo/";
11+
export const GITHUB_URL = "https://github.com/DaleStudy/leetcode-study";
12+
export const YOUTUBE_URL = "https://www.youtube.com/@DaleSeo";

โ€Žindex.html

Lines changed: 2 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -46,27 +46,7 @@
4646
<body style="display: none">
4747
<ds-header></ds-header>
4848

49-
<ds-intro-section id="intro-section">
50-
<ds-hero slot="heading">
51-
ํ•ด์™ธ์ทจ์—…์„ ์œ„ํ•œ ์ปค๋ฎค๋‹ˆํ‹ฐ ๊ธฐ๋ฐ˜ ์•Œ๊ณ ๋ฆฌ์ฆ˜ ์Šคํ„ฐ๋””
52-
</ds-hero>
53-
<ds-button-link
54-
slot="button"
55-
size="big"
56-
variant="primary"
57-
href="https://discord.gg/6TwzdnW6ze"
58-
>
59-
๋””์Šค์ฝ”๋“œ ์ฐธ์—ฌํ•˜๊ธฐ
60-
</ds-button-link>
61-
62-
<ds-image
63-
slot="image"
64-
src="images/roadmap.png"
65-
alt="roadmap"
66-
width="100%"
67-
height="auto"
68-
></ds-image>
69-
</ds-intro-section>
49+
<ds-intro-section id="intro-section"></ds-intro-section>
7050

7151
<ds-language-section>
7252
<ds-image
@@ -103,27 +83,7 @@
10383
</ds-button-link>
10484
</ds-language-section>
10585

106-
<ds-code-review-section>
107-
<ds-hero slot="heading">
108-
์ฝ”๋“œ๋ฆฌ๋ทฐ๋ฅผ ํ†ตํ•ด ์ƒˆ๋กœ์šด ๊ด€์ ์„ ๋ฐฐ์šธ ์ˆ˜ ์žˆ์–ด์š”
109-
</ds-hero>
110-
<ds-button-link
111-
slot="button"
112-
size="big"
113-
variant="primary"
114-
href="https://discord.gg/6TwzdnW6ze"
115-
>
116-
๋””์Šค์ฝ”๋“œ ์ฐธ์—ฌํ•˜๊ธฐ
117-
</ds-button-link>
118-
119-
<ds-image
120-
slot="image"
121-
src="images/review.png"
122-
alt="review"
123-
width="100%"
124-
height="auto"
125-
></ds-image>
126-
</ds-code-review-section>
86+
<ds-code-review-section></ds-code-review-section>
12787

12888
<ds-participant-reviews-section>
12989
<ds-hero>์ฐธ๊ฐ€์ž ํ›„๊ธฐ</ds-hero>

0 commit comments

Comments
ย (0)