Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for user-provided OCR model #932

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Vdaleke
Copy link

@Vdaleke Vdaleke commented Feb 10, 2025

The ocr_model field added to the OcrOptions class with a reference to the BaseOcrModel inheritor class.
In case the options are not one of supported model options, the class from this field is used.

Resolves #931

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

Copy link

mergify bot commented Feb 10, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@Vdaleke Vdaleke force-pushed the feat/user-provided-ocr branch 2 times, most recently from 99b93e2 to d3406aa Compare February 10, 2025 13:00
The ocr_model field added to the OcrOptions class with a reference
 to the BaseOcrModel inheritor class.
In case the options are not one of supported model options,
 the class from this field is used.

Signed-off-by: vdaleke <[email protected]>
@Vdaleke Vdaleke force-pushed the feat/user-provided-ocr branch from d3406aa to 898a497 Compare February 10, 2025 13:04
@vladnosiv
Copy link

Hi @dolfim-ibm !
I saw your comments that you are preparing some changes related to custom models, but maybe consider this PR as a temporary solution ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: add support for user-provided OCR model
2 participants