Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with imageToProximateImagingLocus() in the SAR model #371

Open
oleg-alexandrov opened this issue Apr 19, 2022 · 0 comments
Open

Issue with imageToProximateImagingLocus() in the SAR model #371

oleg-alexandrov opened this issue Apr 19, 2022 · 0 comments

Comments

@oleg-alexandrov
Copy link
Collaborator

It looks to me that the function imageToProximateImagingLocus() in the SAR model has the same issue as imageToRemoteImagingLocus(), which got handled in #361.

The current implementation of imageToProximateImagingLocus() does "tangent = cross(spacecraftVelocity, lookVec)", per https://github.com/USGS-Astrogeology/usgscsm/blob/dev/src/UsgsAstroSarSensorModel.cpp#L659. But that is not the same as the definition of this proximate locus, which says "the proximate imaging locus at a given ground point is the line tangent to the imaging locus at that point".

The "tangent" in the code is the cross-track direction, so it is in the sensor plane. But, since the imaging locus goes from a point in the sensor plane to the ground, the tangent to it also goes towards the ground, rather than being in the sensor plane.

In fact, given that the current SAR implementation assumes that the locus is a line, so all radar, atmosphere, and other physics are ignored, the proximate locus is the same as the locus itself.

If there's no objection, I propose modifying this "proximate" function to call the other one, imageToRemoteImagingLocus().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant