From c8c96ead8f5ef8334537e3a281b557a423d0aa7c Mon Sep 17 00:00:00 2001 From: Laura A DeCicco Date: Wed, 21 Aug 2024 11:15:23 -0500 Subject: [PATCH 1/2] thought this was a requirement, but isn't... --- R/constructNWISURL.R | 1 - 1 file changed, 1 deletion(-) diff --git a/R/constructNWISURL.R b/R/constructNWISURL.R index b10f79ab..1abbb654 100644 --- a/R/constructNWISURL.R +++ b/R/constructNWISURL.R @@ -242,7 +242,6 @@ constructNWISURL <- function(siteNumbers, url <- appendDrURL(baseURL, site_no = siteNumbers, - agency_cd = "USGS", format = "rdb" ) if (nzchar(startDate)) { From fa457383557cd8137dac94800357bdb20c8f7d4e Mon Sep 17 00:00:00 2001 From: Laura A DeCicco Date: Wed, 21 Aug 2024 11:36:22 -0500 Subject: [PATCH 2/2] I think this service is gone now --- tests/testthat/tests_imports.R | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/tests/testthat/tests_imports.R b/tests/testthat/tests_imports.R index 07e38b98..d8c69ac4 100644 --- a/tests/testthat/tests_imports.R +++ b/tests/testthat/tests_imports.R @@ -235,16 +235,6 @@ test_that("importWaterML2 internal test", { expect_is(UserData$value, "numeric") }) -test_that("importWaterML2 external test", { - testthat::skip_on_cran() - url <- "https://waterservices.usgs.gov/nwis/iv/?format=waterml,2.0&sites=01646500¶meterCd=00060,00065" - xml <- getWebServiceData(url) - measurementTS2 <- xml2::xml_find_all(xml, "//wml2:MeasurementTimeseries") - exData <- importWaterML2(measurementTS2) - expect_is(exData$value, "numeric") - expect_gt(nrow(exData), 0) -}) - context("importWQP_noCRAN")