Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stretch tool min/max editing broken in qview #5719

Open
rvwagner opened this issue Jan 31, 2025 · 1 comment
Open

Stretch tool min/max editing broken in qview #5719

rvwagner opened this issue Jan 31, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@rvwagner
Copy link

ISIS version(s) affected: 8.2.0 and 8.3.0, I am not currently able to test if it's still an issue in 9.0.0, but I don't see any relevant entries in the changelog.

Description

In qview, it is no longer possible to manually edit stretch parameters by typing numbers into the min and max text fields at the top of the screen. You can type in new numbers, but the brightnesses of pixels in the image view doesn't change immediately (that's just like before, this part is fine), and hitting "enter" like you used to do to apply the new stretch now reverts the stretch to whatever the current selection in the drop-down menu is (this part is the problem).

It's still possible to use the "advanced" control panel to edit the stretch, but this is, to put it mildly, extremely annoying, and plays very poorly with the workflow of using the selection box to get a rough stretch and tweaking it with the toolbar fields- when the Advanced control panel ends up behind the main window, it's much more difficult to bring forward than it should be, at least on MacOS. Also any interaction to bring it back is more steps than just clicking in the min/max fields.

Possible Solution

This might be a mix-up in how the controls are tagged in QT? Maybe hitting "enter" is telling the interface to do the action for the drop-down menu, rather than the action for the current text box? I don't know how this is handled on the back end.

@rvwagner rvwagner added the bug Something isn't working label Jan 31, 2025
@lwellerastro
Copy link
Contributor

I've confirmed this for 8.3.0 on a linux OS. This was likely introduced via the new drop down menu (Default, Best, etc.), #5289. The response for any action having to do with the stretch tool is quite slow.

The Advanced control panel on linux is always on top for me, but maybe that's due to my general windowing options (honestly don't know). Even still, the user ought to be able to tweak the min/max dn's in the main tool panel as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

2 participants