Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IP Allow List on Install #64

Open
WillStrohl opened this issue Jul 15, 2020 · 3 comments
Open

Update IP Allow List on Install #64

WillStrohl opened this issue Jul 15, 2020 · 3 comments

Comments

@WillStrohl
Copy link
Member

It would be useful for the IUpgradeable feature to be added that automatically adds the current IP address that's installing the module so it doesn't need to be done via SQL in production environments.

@mitchelsellers
Copy link
Collaborator

Just a note on this one, I've tried this and it isn't necessarily consistent in the context of IUpgradable due to when it is triggered and how proxy or internal routing might work. (At least that was my test.)

@WillStrohl
Copy link
Member Author

Ah.. Good point. Maybe another method could be explored if we can't find something more consistent during IUpgradeable.

@mitchelsellers
Copy link
Collaborator

I would agree, totally great idea Will, just not sure of the best "accurate" way to make this happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants