From ad93b3b846895a719fdbf466331fbbd70bbb7f00 Mon Sep 17 00:00:00 2001 From: Timo Breumelhof Date: Thu, 16 Nov 2023 15:48:21 +0100 Subject: [PATCH 1/6] Improve Manigest Cleanup documentation #704 --- content/tutorials/extensions/dnn-manifest-schema/index.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/content/tutorials/extensions/dnn-manifest-schema/index.md b/content/tutorials/extensions/dnn-manifest-schema/index.md index 779a6691a..be8242980 100644 --- a/content/tutorials/extensions/dnn-manifest-schema/index.md +++ b/content/tutorials/extensions/dnn-manifest-schema/index.md @@ -302,7 +302,8 @@ Some component types are applicable only to the package type of the same name; g * [`Cleanup`](https://www.dnnsoftware.com/wiki/cleanup-component). List of files that must be deleted during installation or upgrade of the package. - You can list the files individually in the manifest. + - You can list the files individually in the manifest. + - You can also remove folders. These have to be empty, so you need to remove the files first. ``` @@ -315,6 +316,9 @@ Some component types are applicable only to the package type of the same name; g ... + + DesktopModules/MyModule/DeleteFolder + ``` @@ -336,7 +340,7 @@ Some component types are applicable only to the package type of the same name; g Notes: * You can specify more than one globbing pattern on the same line by separating each pattern with `;` * More information on supported globbing patterns can be found at the [Microsoft.Extensions.FileSystemGlobbing documentation](https://docs.microsoft.com/en-us/dotnet/api/microsoft.extensions.filesystemglobbing.matcher?view=dotnet-plat-ext-3.1#remarks) - * Globbing patterns can only be used to match files, not directories (if you need to delete a directory, first it needs to be empty, then you need to use one of the above methods to delete the actual directory). + * Globbing patterns can only be used to match files and folders inside a folder. not the folder itself.(if you need to delete a directory, first it needs to be empty, then you need to use one of the above methods to delete the actual directory). * All methods take paths relative to the application root folder, for that reason `..` is intentionally not supported with globbing patterns in this component. See also: From 42150b69f09cd2d9dff318ac06d4568dfa1e6dd7 Mon Sep 17 00:00:00 2001 From: Timo Breumelhof Date: Fri, 17 Nov 2023 11:11:44 +0100 Subject: [PATCH 2/6] Restrucure sentence as suggested by david #705 --- content/tutorials/extensions/dnn-manifest-schema/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/tutorials/extensions/dnn-manifest-schema/index.md b/content/tutorials/extensions/dnn-manifest-schema/index.md index be8242980..59a5b76cf 100644 --- a/content/tutorials/extensions/dnn-manifest-schema/index.md +++ b/content/tutorials/extensions/dnn-manifest-schema/index.md @@ -340,7 +340,7 @@ Some component types are applicable only to the package type of the same name; g Notes: * You can specify more than one globbing pattern on the same line by separating each pattern with `;` * More information on supported globbing patterns can be found at the [Microsoft.Extensions.FileSystemGlobbing documentation](https://docs.microsoft.com/en-us/dotnet/api/microsoft.extensions.filesystemglobbing.matcher?view=dotnet-plat-ext-3.1#remarks) - * Globbing patterns can only be used to match files and folders inside a folder. not the folder itself.(if you need to delete a directory, first it needs to be empty, then you need to use one of the above methods to delete the actual directory). + * Globbing patterns can only be used to match files and folders inside a folder (not the folder itself) If you need to delete a directory, first it needs to be empty, then you need to use one of the above methods to delete the actual directory. * All methods take paths relative to the application root folder, for that reason `..` is intentionally not supported with globbing patterns in this component. See also: From bfb6cbd23d9b26692f1fad1ac5b72de97109a509 Mon Sep 17 00:00:00 2001 From: Timo Breumelhof Date: Fri, 17 Nov 2023 11:12:52 +0100 Subject: [PATCH 3/6] sigh, missed a dot.. #705 --- content/tutorials/extensions/dnn-manifest-schema/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/tutorials/extensions/dnn-manifest-schema/index.md b/content/tutorials/extensions/dnn-manifest-schema/index.md index 59a5b76cf..8cdd815f9 100644 --- a/content/tutorials/extensions/dnn-manifest-schema/index.md +++ b/content/tutorials/extensions/dnn-manifest-schema/index.md @@ -340,7 +340,7 @@ Some component types are applicable only to the package type of the same name; g Notes: * You can specify more than one globbing pattern on the same line by separating each pattern with `;` * More information on supported globbing patterns can be found at the [Microsoft.Extensions.FileSystemGlobbing documentation](https://docs.microsoft.com/en-us/dotnet/api/microsoft.extensions.filesystemglobbing.matcher?view=dotnet-plat-ext-3.1#remarks) - * Globbing patterns can only be used to match files and folders inside a folder (not the folder itself) If you need to delete a directory, first it needs to be empty, then you need to use one of the above methods to delete the actual directory. + * Globbing patterns can only be used to match files and folders inside a folder (not the folder itself). If you need to delete a directory, first it needs to be empty, then you need to use one of the above methods to delete the actual directory. * All methods take paths relative to the application root folder, for that reason `..` is intentionally not supported with globbing patterns in this component. See also: From e8aa83a0cc1de3d488b20626b62855a7b8a2dca5 Mon Sep 17 00:00:00 2001 From: David Poindexter Date: Fri, 17 Nov 2023 13:44:19 -0500 Subject: [PATCH 4/6] Update content/tutorials/extensions/dnn-manifest-schema/index.md --- content/tutorials/extensions/dnn-manifest-schema/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/tutorials/extensions/dnn-manifest-schema/index.md b/content/tutorials/extensions/dnn-manifest-schema/index.md index 8cdd815f9..adeddac8f 100644 --- a/content/tutorials/extensions/dnn-manifest-schema/index.md +++ b/content/tutorials/extensions/dnn-manifest-schema/index.md @@ -340,7 +340,7 @@ Some component types are applicable only to the package type of the same name; g Notes: * You can specify more than one globbing pattern on the same line by separating each pattern with `;` * More information on supported globbing patterns can be found at the [Microsoft.Extensions.FileSystemGlobbing documentation](https://docs.microsoft.com/en-us/dotnet/api/microsoft.extensions.filesystemglobbing.matcher?view=dotnet-plat-ext-3.1#remarks) - * Globbing patterns can only be used to match files and folders inside a folder (not the folder itself). If you need to delete a directory, first it needs to be empty, then you need to use one of the above methods to delete the actual directory. + * Globbing patterns can only be used to match files, not directories (if you need to delete a directory, first it needs to be empty, then you need to use one of the above methods to delete the actual directory). * All methods take paths relative to the application root folder, for that reason `..` is intentionally not supported with globbing patterns in this component. See also: From 0bf5cef7b070490d9ddf5aff72956d7deed89583 Mon Sep 17 00:00:00 2001 From: David Poindexter Date: Fri, 17 Nov 2023 13:49:50 -0500 Subject: [PATCH 5/6] Update content/tutorials/extensions/dnn-manifest-schema/index.md --- content/tutorials/extensions/dnn-manifest-schema/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/tutorials/extensions/dnn-manifest-schema/index.md b/content/tutorials/extensions/dnn-manifest-schema/index.md index adeddac8f..c2bbdc197 100644 --- a/content/tutorials/extensions/dnn-manifest-schema/index.md +++ b/content/tutorials/extensions/dnn-manifest-schema/index.md @@ -303,7 +303,7 @@ Some component types are applicable only to the package type of the same name; g * [`Cleanup`](https://www.dnnsoftware.com/wiki/cleanup-component). List of files that must be deleted during installation or upgrade of the package. - You can list the files individually in the manifest. - - You can also remove folders. These have to be empty, so you need to remove the files first. + - You can also remove folders. These have to be empty, so you need to remove the files first. ``` From 081c7005c3415c1d97418b227b76ca1bb86133b0 Mon Sep 17 00:00:00 2001 From: David Poindexter Date: Fri, 17 Nov 2023 13:49:58 -0500 Subject: [PATCH 6/6] Update content/tutorials/extensions/dnn-manifest-schema/index.md --- content/tutorials/extensions/dnn-manifest-schema/index.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/content/tutorials/extensions/dnn-manifest-schema/index.md b/content/tutorials/extensions/dnn-manifest-schema/index.md index c2bbdc197..d5dbd2bda 100644 --- a/content/tutorials/extensions/dnn-manifest-schema/index.md +++ b/content/tutorials/extensions/dnn-manifest-schema/index.md @@ -316,9 +316,9 @@ Some component types are applicable only to the package type of the same name; g ... - - DesktopModules/MyModule/DeleteFolder - + + DesktopModules/MyModule/DeleteFolder + ```