Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajax Modal not closable & Icons not appearing #62

Open
sys-arch opened this issue Nov 27, 2024 · 4 comments
Open

Ajax Modal not closable & Icons not appearing #62

sys-arch opened this issue Nov 27, 2024 · 4 comments

Comments

@sys-arch
Copy link

The modals that notify you of AJAX errors block the site and do not allow you to close them so a button or icon had to be added to close them

The transparent button/link on the top right, called Menu, does not work or does nothing, whether you are logged in or not.

imagen

@DNA-styx
Copy link
Owner

DNA-styx commented Nov 27, 2024

Thanks for reporting (and the screenshot!)

AJAX: Will have a look. Do you know if there is an easy way to force that error to appear?

Icons: There's a function breaking upstream change with SourceBan 1.8.x that affects the icons (#61) . Have a fix in dev, will push a new beta out with a fix shortly.

@DNA-styx DNA-styx changed the title Some bugs Ajax Modal not closable & Icons not appearing Nov 27, 2024
@DNA-styx
Copy link
Owner

DNA-styx commented Nov 27, 2024

Icons: fix just pushed out in 0.3.6 release

About the Link menu not working did you mean the below? It currently just has placeholders Link1, Link2, Link3. You can edit the links by opening core-> navbar.tpl and scrolling to the bottom , but you will lose these changes when you update the theme, I'll work on a way so that updating the theme will not reset these links.

image

@sys-arch
Copy link
Author

Yes, that thing you show on screenshot is what not working. Maybe you can change it to put login or admin menu (or both, show login when is not logged in and admin menu when it is)

@DNA-styx DNA-styx self-assigned this Dec 4, 2024
@DNA-styx
Copy link
Owner

DNA-styx commented Dec 4, 2024

Thanks for confirming @sys-arch .

I've tweaked how the links work, they are now called from a separate file.

image

I've also added a go in/out to the drop down as you suggested. I've also added an admin panel link to see if it is useful. Tried the entire admin menu, but it seemed a bit too much.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants