-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comparison with tensorflow1/2 implementation #56
Comments
Possibly some related discussion in #20 It is hard to say yet how far the optimizations can go, but we expect slightly lower performance (in terms of wall-clock time) than TF1 because PyTorch is eager. However this should not be significant after code is written to follow PyTorch's guidelines, and it will provide much cleaner code overall. We chose PyTorch over TF2 partially because of majority vote. |
Hello, |
yea I meant about wall clock time or any other aspect which you may have thought about, specifically compared to TF2. It seemed to me that there is a tendency towards PyTorch more than TF2 but I couldn't guess why. and was wondering if there is any advantage in using PyTorch compared to TF2. |
i guess reading those two issues will give you the answer then: |
I wanted to ask if you expect better performance using pytorch in stable-baselines3 than if it was going to be implemented with tensorflow2 ( or compared to the currently implemented tensorflow1). If so, from what aspects do you expect the advantages be in the end?
The text was updated successfully, but these errors were encountered: