Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use path to testfiles instead of copying testfiles to build directory #1417

Open
lenaploetzke opened this issue Feb 20, 2025 · 0 comments
Open
Labels
CMake Is about the CMake build system discussion priority: medium Should be solved within half a year

Comments

@lenaploetzke
Copy link
Collaborator

lenaploetzke commented Feb 20, 2025

Feature request

Currently, the folder test/testfiles is copied into the build folder when building the tests.
This is not necessary, you can also set the path to the test files in cmake.
This is especially a problem if some of the testfiles get big.
If we use the paths solution, the tests does not work anymore if the testfiles in the main repository are deleted.
The current solution works and is simple.

!!! Update: !!!
I have noticed that the current solution does not work everywhere.
Some tests cannot be run individually, for example ./test/t8_cmesh/t8_gtest_cmesh_set_join_by_vertices_serial gives the error Failed to open test/testfiles/test_cube_unstructured_1.inp.

The test files are currently copied to a directory called build/test/test/testfiles. When I place them in a build/test/testfiles directory, the individual tests run as expected, but the general test suite fails.

I expect that the solution described above will also solve this problem.

Estimated priority
"Priority: medium" Should be solved within half a year

@lenaploetzke lenaploetzke added CMake Is about the CMake build system discussion labels Feb 20, 2025
@lenaploetzke lenaploetzke added the priority: medium Should be solved within half a year label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake Is about the CMake build system discussion priority: medium Should be solved within half a year
Projects
Status: Todo
Development

No branches or pull requests

1 participant