Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check line endings in CI #1392

Open
lukasdreyer opened this issue Feb 12, 2025 · 4 comments
Open

Check line endings in CI #1392

lukasdreyer opened this issue Feb 12, 2025 · 4 comments
Assignees

Comments

@lukasdreyer
Copy link
Collaborator

Feature request

Is your feature request related to a problem? Please describe.
Sometimes, files with line endings different to all the other files in t8code are introduced.

Describe the solution or feature you'd like
A CI workflow, that checks for correct lineendings

Describe alternatives you've considered
None

Estimated priority

"Priority: medium" Should be solved within half a year

Additional context
#1391

@Davknapp
Copy link
Collaborator

I propose to install a similar workflow as with the typo or indent workflow. We can probably check such things in a pre-commit hook and in a workflow if we write a proper-script for it.

@Davknapp Davknapp self-assigned this Feb 17, 2025
@Davknapp
Copy link
Collaborator

Take care of trailing whitespace, too.

@sandro-elsweijer
Copy link
Collaborator

Our indent script checks that. But it seems like the api folder and some more folders were/are missing from the find_all_source_files.scp script. The solution decided on in the dev meeting is to change the find_all_source_files.scp in such a way, that it is a blacklist instead of a whitelist.

@sandro-elsweijer
Copy link
Collaborator

Our indent script checks that. But it seems like the api folder and some more folders were/are missing from the find_all_source_files.scp script. The solution decided on in the dev meeting is to change the find_all_source_files.scp in such a way, that it is a blacklist instead of a whitelist.

Okay I have to correct myself here, clang format cannot check for correct line endings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants