From b339976551f7d5f585e2ad9d61f9ed50790a8ae3 Mon Sep 17 00:00:00 2001 From: Drew Leonard Date: Wed, 4 Sep 2024 14:38:57 +0100 Subject: [PATCH] Skip failing test on command line instead --- .github/workflows/main.yml | 2 +- dkist/data/tests/test_sample.py | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index a83f0245..4699ade9 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -92,7 +92,7 @@ jobs: with: python-version: '3.10' test_extras: tests - test_command: pytest --pyargs dkist + test_command: pytest --pyargs dkist -k "not test_fail" # We have to work around a github runner bug here: https://github.com/actions/runner/issues/2788#issuecomment-2145922705 upload_to_pypi: ${{ startsWith(github.ref || format('{0}{1}', 'refs/tags/', github.event.release.tag_name), 'refs/tags/v') && !endsWith(github.ref || format('{0}{1}', 'refs/tags/', github.event.release.tag_name), '.dev') }} secrets: diff --git a/dkist/data/tests/test_sample.py b/dkist/data/tests/test_sample.py index 88b33177..10ba7046 100644 --- a/dkist/data/tests/test_sample.py +++ b/dkist/data/tests/test_sample.py @@ -29,7 +29,6 @@ def test_module_getattr(mocker, attrname): mock.assert_has_calls([call(attrname), call().__getitem__(0)]) -@pytest.mark.skipif(pytest.config.getvalue("environment") == "publish") @pytest.mark.internet_off def test_fail(tmp_sample_dir): """