Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_selected is not an argument #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

is_selected is not an argument #46

wants to merge 1 commit into from

Conversation

ecomodeller
Copy link
Member

@ecomodeller ecomodeller commented Jun 27, 2023 •
edited
Loading

This errors appears when I try to upload a file
image

The draft "solution" is to remove the is_selected.

Additional changes are due to formatting with black.

@PaulDanielML
Copy link
Collaborator

Seems like the E-charts python API changed.
We can either pin its version to the previous one or just remove those options as you have done.
The side effect of that might be performance issues when dealing with large datasets. I would have to find out what the new default value for the new "is_selected" option is. My guess would be "True".

@PaulDanielML
Copy link
Collaborator

Seems like the change was introduced in 2.0.3, so using 2.0.2 would be the easy fix. Problem is that this is a sub dependency of streamlit-echarts, which will just install the newest version.
So let's just remove the argument for now, I can look up the way of achieving the same behaviour when things are a bit less busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulDanielML PaulDanielML Awaiting requested review from PaulDanielML

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ecomodeller @PaulDanielML