Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFSU.read() very slow on AMD CPU or linux #709

Open
bhlevca opened this issue Aug 1, 2024 · 12 comments
Open

DFSU.read() very slow on AMD CPU or linux #709

bhlevca opened this issue Aug 1, 2024 · 12 comments

Comments

@bhlevca
Copy link

bhlevca commented Aug 1, 2024

Describe the bug
A clear and concise description of what the bug is.
I am expecting some differences but not 30x.

There is something in the read algorithm that may be favoured by Intel CPU.

I have a code

dfs = Dfsu(filename)
dsp = dfs.read(x=x, y=y)

The dfsu file is large ~ 52 GB.
The same read operation takes 17-18 sec on an Intel i7 CPU laptop running Windows 10 and 420 sec on a powerful AMD Ryzen 3950X desktop running Linux.

To Reproduce
Steps to reproduce the behavior:

Get a large DFSU file and use read (x,y)

System information:

  • Python version 3.12.4
  • MIKE IO version 1.7.1
@jsmariegaard
Copy link
Member

@JesperGr - this most be related to MIKE Core ...

@bhlevca
Copy link
Author

bhlevca commented Sep 19, 2024

@JesperGr - this most be related to MIKE Core ...

Is there anything we can do about it? It may be related to what you do in the read function. Is it using pandas in the underlying code? I know that pandas code is slower on AMD platforms.

@jsmariegaard
Copy link
Member

@bhlevca could you try with a profiler - I hear Scalene is great https://github.com/plasma-umass/scalene :-)

@bhlevca
Copy link
Author

bhlevca commented Sep 19, 2024

I guess that I need to use the mikeio source files to do useful profiling

@jsmariegaard
Copy link
Member

You get those when you install MIKE IO (pure python)

@bhlevca
Copy link
Author

bhlevca commented Sep 20, 2024

Usually, When I debug, I point Pythonpath to the git folder
From what you're saying, it will be enough to use the pip installed mikeio for the profiling purposes

@bhlevca
Copy link
Author

bhlevca commented Oct 25, 2024

I used Scalene but i didn't get extra information other than the read() function take minutes on an AMD CPU whether is Linux or Windows. Scalene did not get inside theread() function.
I looked at mikecore source files but it is complex and it would be easier for you to determine the problem if you have access to an AMD CPU.

I tested on an AMD computer with dual boot:

- on Windows on an Intel CPU   -  16 sec
- on  Windows on an AMD CPU    -  85 sec
- on Linux on the same AMS CPU - 442 sec

If you don't have the time please give me some instruction where to look, what files and what is calling what and how I can debug this thing.. Thanks

@jsmariegaard
Copy link
Member

@JesperGr do you know anything about read speed of dfsu files on AMD using MIKE Core?

@bhlevca
Copy link
Author

bhlevca commented Oct 27, 2024

I don't, but if you give some guidance on how to do it, I will try to test the MIKE CORE read()

@JesperGr
Copy link

I am not aware of any performance differences when reading DFS files for AMD compared to Intel processors. Common performance issues are usually related to disc performance and not processor performance.

To test that, you could try run a raw MIKE-Core Python read test, i.e. not involving mikeio at all. Something similar to the ReadingDfs2File method in:

https://github.com/DHI/mikecore-python/blob/master/tests/examples_dfs2.py

which loops over all items and time steps.

@bhlevca
Copy link
Author

bhlevca commented Oct 28, 2024 via email

@bhlevca
Copy link
Author

bhlevca commented Oct 29, 2024

You are right. The disk transfer speed is the main problem.
I tested on various disks, including SDD, and the read() function time varies wildly.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants