-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFSU.read() very slow on AMD CPU or linux #709
Comments
@JesperGr - this most be related to MIKE Core ... |
Is there anything we can do about it? It may be related to what you do in the read function. Is it using pandas in the underlying code? I know that pandas code is slower on AMD platforms. |
@bhlevca could you try with a profiler - I hear Scalene is great https://github.com/plasma-umass/scalene :-) |
I guess that I need to use the mikeio source files to do useful profiling |
You get those when you install MIKE IO (pure python) |
Usually, When I debug, I point Pythonpath to the git folder |
I used Scalene but i didn't get extra information other than the read() function take minutes on an AMD CPU whether is Linux or Windows. Scalene did not get inside the I tested on an AMD computer with dual boot:
If you don't have the time please give me some instruction where to look, what files and what is calling what and how I can debug this thing.. Thanks |
@JesperGr do you know anything about read speed of dfsu files on AMD using MIKE Core? |
I don't, but if you give some guidance on how to do it, I will try to test the MIKE CORE read() |
I am not aware of any performance differences when reading DFS files for AMD compared to Intel processors. Common performance issues are usually related to disc performance and not processor performance. To test that, you could try run a raw MIKE-Core Python read test, i.e. not involving mikeio at all. Something similar to the ReadingDfs2File method in: https://github.com/DHI/mikecore-python/blob/master/tests/examples_dfs2.py which loops over all items and time steps. |
There is a known problem with Pandas performance on AMD processors when
compared with Intel processors because of the MKL library.
I assumed that a 3D DFSU has the same issue because I thought that some
calculations are needed to decrypt when reading the file.
I am going to put the file on a SSD to test your assumption. Also, I am
going to try your suggestions on the Intel laptop and on the big AMD
workstation on the current disks
…On Mon, Oct 28, 2024, 06:56 Jesper Grooss ***@***.***> wrote:
I am not aware of any performance differences when reading DFS files for
AMD compared to Intel processors. Common performance issues are usually
related to disc performance and not processor performance.
To test that, you could try run a raw MIKE-Core Python read test, i.e. not
involving mikeio at all. Something similar to the ReadingDfs2File method in:
https://github.com/DHI/mikecore-python/blob/master/tests/examples_dfs2.py
which loops over all items and time steps.
—
Reply to this email directly, view it on GitHub
<#709 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABMRXVVNEKHSOP472ANPYDZ5YC6HAVCNFSM6AAAAABLZSLYZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBRGI2TINZQGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
You are right. The disk transfer speed is the main problem. |
Describe the bug
A clear and concise description of what the bug is.
I am expecting some differences but not 30x.
There is something in the read algorithm that may be favoured by Intel CPU.
I have a code
The dfsu file is large ~ 52 GB.
The same read operation takes 17-18 sec on an Intel i7 CPU laptop running Windows 10 and 420 sec on a powerful AMD Ryzen 3950X desktop running Linux.
To Reproduce
Steps to reproduce the behavior:
Get a large DFSU file and use
read (x,y)
System information:
The text was updated successfully, but these errors were encountered: