-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of 'network_data' type to 'network_graph' #1
Comments
I've refactored the central network data type, and renamed it from As requested here, users now specify the type of the network graph when assembling the data, which means there is an additional 'graph_type' user input in the |
I'm in the process of copying all modules from the tagung repository into this plugin, with some minor adjustments so that they don't error out. One thing that has changed in the data type interface is the |
Ok, so I've moved all of the tagung modules in here, most of them at least don't break, except for the closeness_rank_list which I might not have the right example data for, and the cutpoints one where there is an issue with a numpy data type, which might also be related to my example data (added a TODO note in the source code). I've not looked at the module code at all, apart from refactoring the So, I think at this point @CBurge95 could take over, make sure my changes haven't broken anything, maybe write some tests using different graph-type example network graph data inputs, and make sure the code doesn't break for unexpected inputs (or breaks but gives useful error messages). Once that's done, maybe submit it for review to someone else, and then me. I'll have a look at the code part then. |
Lacking an idea where to put this information, I'll put all the notes I have regarding the refactoring of the 'network_data' type (that was used in the old 'network_analysis' plugin) to the simpler 'network_graph' data type into this issue.
The text was updated successfully, but these errors were encountered: